Bug 755964 - gdm kills process running pam at logout
Summary: gdm kills process running pam at logout
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: gdm
Version: 16
Hardware: i686
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Ray Strode [halfline]
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-22 14:48 UTC by Anders Blomdell
Modified: 2013-02-14 02:21 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-02-14 02:21:50 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Anders Blomdell 2011-11-22 14:48:47 UTC
Description of problem:

Gdm kill the process running PAM/gdm-password before it has finished it's pam_close_session actions. If one uses pam_namespace, this soon leads to an explosion of mounts.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. configure pam_namespace
2. login/logout a few times through gdm
  
Actual results:

A lot of mounts starts to appear in the global namespace.


Expected results:

Unchanged mounts in the global namespace.

Additional info:

https://bugzilla.redhat.com/show_bug.cgi?id=755216

Comment 1 Ray Strode [halfline] 2011-12-21 16:42:53 UTC
Are you sure it's gdm killing the process?  There have been bugs in the past where it has prematurely killed the session, but I'm thought that was all mopped up now.  I did a quick test and it works here, but there very well may be a race I guess.

I'll look through the code and see if I spot anything.

Comment 2 Ray Strode [halfline] 2011-12-21 16:55:43 UTC
Alright, I do see a problem. When the session exits we quit the event loop and then unref the slave object which ultimately forces the worker process to die.  We wait 3 seconds in this code path and bail after that.

I think a better approach is to disown the worker (stopping watching it, free its associated book keeping objects etc) than to kill it after 3 seconds.  If it ends up hanging instead of just being really slow then we can fix the hang in the pam module instead of second guessing the pam module

Comment 3 Fedora End Of Life 2013-01-17 00:20:50 UTC
This message is a reminder that Fedora 16 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 16. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '16'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 16's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 16 is end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" and open it against that version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Fedora End Of Life 2013-02-14 02:21:53 UTC
Fedora 16 changed to end-of-life (EOL) status on 2013-02-12. Fedora 16 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.