Bug 756856 - Review Request: python-pyflag - Forensic and Log Analysis GUI
Summary: Review Request: python-pyflag - Forensic and Log Analysis GUI
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-24 20:59 UTC by Soumya Kanti Chakraborty
Modified: 2012-01-30 19:02 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-01-30 19:02:48 UTC
Type: ---
Embargoed:
gwync: fedora-review?


Attachments (Terms of Use)

Description Soumya Kanti Chakraborty 2011-11-24 20:59:15 UTC
Spec URL: http://soumya.fedorapeople.org/pyflag/python-pyflag.spec
SRPM URL: http://soumya.fedorapeople.org/pyflag/python-pyflag-0.85-1.fc16.src.rpm
Description: This application is designed to assist IT security professionals with analyzing log files, tcpdump files and hard disk images for forensic
evidence.It performs data analysis using a MYSQL database.

Comment 1 Gwyn Ciesla 2011-11-28 16:21:33 UTC
It'll start on this. . .

Comment 2 Gwyn Ciesla 2011-11-28 16:59:55 UTC
Doesn't build for me:

yte-compiling python modules (optimized versions) ...
conf.py
make[2]: Leaving directory `/home/limb/rpmbuild/BUILD/pyflag-0.85'
make[1]: Leaving directory `/home/limb/rpmbuild/BUILD/pyflag-0.85'
+ sed -i -e '1i#!/usr/bin/python' /home/limb/rpmbuild/BUILDROOT/python-pyflag-0.85-1.fc16.x86_64//usr/bin/conf.py
+ for file in '$RPM_BUILD_ROOT//usr/lib64/python2.7/site-packages/pyflag/{jpeg_carver,Tester,regkey_load,FlagHTTPServer,mspst,FlagGTKServer,examine,pdf_carver,pyclamd,zip_carver}.py'
+ chmod a+x /home/limb/rpmbuild/BUILDROOT/python-pyflag-0.85-1.fc16.x86_64//usr/lib64/python2.7/site-packages/pyflag/jpeg_carver.py
chmod: cannot access `/home/limb/rpmbuild/BUILDROOT/python-pyflag-0.85-1.fc16.x86_64//usr/lib64/python2.7/site-packages/pyflag/jpeg_carver.py': No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.uEoW3m (%install)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.uEoW3m (%install)

Comment 3 Soumya Kanti Chakraborty 2011-12-01 20:02:24 UTC
(In reply to comment #2)
> Doesn't build for me:
> 
> yte-compiling python modules (optimized versions) ...
> conf.py
> make[2]: Leaving directory `/home/limb/rpmbuild/BUILD/pyflag-0.85'
> make[1]: Leaving directory `/home/limb/rpmbuild/BUILD/pyflag-0.85'
> + sed -i -e '1i#!/usr/bin/python'
> /home/limb/rpmbuild/BUILDROOT/python-pyflag-0.85-1.fc16.x86_64//usr/bin/conf.py
> + for file in
> '$RPM_BUILD_ROOT//usr/lib64/python2.7/site-packages/pyflag/{jpeg_carver,Tester,regkey_load,FlagHTTPServer,mspst,FlagGTKServer,examine,pdf_carver,pyclamd,zip_carver}.py'
> + chmod a+x
> /home/limb/rpmbuild/BUILDROOT/python-pyflag-0.85-1.fc16.x86_64//usr/lib64/python2.7/site-packages/pyflag/jpeg_carver.py
> chmod: cannot access
> `/home/limb/rpmbuild/BUILDROOT/python-pyflag-0.85-1.fc16.x86_64//usr/lib64/python2.7/site-packages/pyflag/jpeg_carver.py':
> No such file or directory
> error: Bad exit status from /var/tmp/rpm-tmp.uEoW3m (%install)

There were some build issues due to building in 64bit machines. Problems were mostly due to lib configurations of make for 32 and 64 bits. Corrected the SPEC file and SRPM fixing the issue. Please find the link below - 

Spec URL:http://soumya.fedorapeople.org/pyflag/python-pyflag.spec 
SRPM URL:http://soumya.fedorapeople.org/pyflag/python-pyflag-0.85-2.fc16.src.rpm

Comment 4 Gwyn Ciesla 2011-12-01 20:41:25 UTC
Builds now. :)

rpmlint:

python-pyflag.src: W: spelling-error %description -l en_US tcpdump -> dumpster
The value of this tag appears to be misspelled. Please double-check.

python-pyflag.src: W: invalid-url Source0: http://sourceforge.net/projects/pyflag/files/pyflag/0.85/pyflag-0.85.tar.bz2 <urlopen error [Errno -2] Name or service not known>
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 0 errors, 2 warnings.

python-pyflag.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/pyflag/index.so.0.0.0 index.so.0()(64bit)
 and several similar.

Also, lots of 

python-pyflag.x86_64: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyflag/FileFormats/PCAP.py

And then: 

python-pyflag.x86_64: W: manual-page-warning /usr/share/man/man1/pyflag.1.gz 28: warning: numeric expression expected (got `)')
This man page may contain problems that can cause it not to be formatted as
intended.

python-pyflag.x86_64: W: no-manual-page-for-binary ewfexport
Each executable in standard binary directories should have a man page.

python-pyflag.x86_64: W: no-manual-page-for-binary ewfacquire
Each executable in standard binary directories should have a man page.

python-pyflag.x86_64: W: no-manual-page-for-binary remote_server
Each executable in standard binary directories should have a man page.

python-pyflag.x86_64: W: no-manual-page-for-binary pyflash
Each executable in standard binary directories should have a man page.

python-pyflag.x86_64: W: no-manual-page-for-binary evtool
Each executable in standard binary directories should have a man page.   

python-pyflag.x86_64: W: no-manual-page-for-binary sgzip
Each executable in standard binary directories should have a man page.

python-pyflag.x86_64: W: no-manual-page-for-binary conf.py
Each executable in standard binary directories should have a man page.

python-pyflag.x86_64: W: no-manual-page-for-binary ewfverify
Each executable in standard binary directories should have a man page.

python-pyflag.x86_64: W: no-manual-page-for-binary ewfinfo
Each executable in standard binary directories should have a man page.

python-pyflag.x86_64: W: no-manual-page-for-binary iowrapper
Each executable in standard binary directories should have a man page.   

python-pyflag.x86_64: W: no-manual-page-for-binary pyflag_launch
Each executable in standard binary directories should have a man page.

python-pyflag-devel.x86_64: E: description-line-too-long C The package pyflag-devel contains the static libraries needed for Pyflag Development
Your description lines must not exceed 80 characters. If a line is exceeding
this number, cut it to fit in two lines.

python-pyflag-devel.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

python-pyflag-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Comment 5 Soumya Kanti Chakraborty 2011-12-02 15:37:15 UTC
(In reply to comment #4)
> Builds now. :)
> 
> rpmlint:
> 
> python-pyflag.src: W: spelling-error %description -l en_US tcpdump -> dumpster
> The value of this tag appears to be misspelled. Please double-check.

I can maximum keep it is as tcp dump for rpmlint :)
> 
> python-pyflag.src: W: invalid-url Source0:
> http://sourceforge.net/projects/pyflag/files/pyflag/0.85/pyflag-0.85.tar.bz2
> <urlopen error [Errno -2] Name or service not known>
> The value should be a valid, public HTTP, HTTPS, or FTP URL.

Regarding the source I guess its only the source I downloaded it from(just paste the link in the browser and you end up downloading the tarball) 

> 
> python-pyflag.x86_64: W: private-shared-object-provides
> /usr/lib64/python2.7/site-packages/pyflag/index.so.0.0.0 index.so.0()(64bit)
>  and several similar.

The problem with this warning is this requires pre scan filtering. But according to http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering this filtering can only be done to packages having this below two factors - 

* Noarch packages
* Architecture specific packages with no binaries in $PATH (e.g. /bin,  /usr/bin, /sbin, /sbin) or libexecdir and no system libs in libdir. This includes all of the subpackages generated from the spec file.

The problem is pyflag doesn't fall under any of the categories of above two packages, so please suggest me what to do (also to quote the upstream is absolutely not responding state, I mark them as dead for queries)

> 
> Also, lots of 
> 
> python-pyflag.x86_64: E: incorrect-fsf-address
> /usr/lib/python2.7/site-packages/pyflag/FileFormats/PCAP.py

As I already mentioned I have several times mailed the developers, the mailing list, pinged them in IRC but they have never responded. This error can only be corrected buy the upstream which is dead and I don't feel patching each file is a feasible option for a package maintainer. So again let me know your views.


 
> And then: 
> 
> python-pyflag.x86_64: W: manual-page-warning /usr/share/man/man1/pyflag.1.gz
> 28: warning: numeric expression expected (got `)')
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary ewfexport
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary ewfacquire
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary remote_server
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary pyflash
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary evtool
> Each executable in standard binary directories should have a man page.   
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary sgzip
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary conf.py
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary ewfverify
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary ewfinfo
> Each executable in standard binary directories should have a man page.
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary iowrapper
> Each executable in standard binary directories should have a man page.   
> 
> python-pyflag.x86_64: W: no-manual-page-for-binary pyflag_launch
> Each executable in standard binary directories should have a man page.
> 
All this are errors related to either man page or non availability of the man page which again leads to getting into upstream, same problem ..need guidance.

> python-pyflag-devel.x86_64: E: description-line-too-long C The package
> pyflag-devel contains the static libraries needed for Pyflag Development
> Your description lines must not exceed 80 characters. If a line is exceeding
> this number, cut it to fit in two lines.

Will do this.
 
> python-pyflag-devel.x86_64: W: only-non-binary-in-usr-lib
> There are only non binary files in /usr/lib so they should be in /usr/share.

Should I move all files in devel to /usr/share ?
 
> python-pyflag-devel.x86_64: W: no-documentation
> The package contains no documentation (README, doc, etc). You have to include
> documentation files.

Nothing to add here as documents as if devel in installed by default the original package will be installed and that has documentations.

Comment 6 Soumya Kanti Chakraborty 2011-12-06 21:54:02 UTC
(In reply to comment #5)

Any directions on the above comment ?

Comment 7 Gwyn Ciesla 2011-12-21 15:38:27 UTC
Possibly move the files in /usr/lib to devel, unless they're needed at runtime.

Comment 8 Soumya Kanti Chakraborty 2012-01-09 17:12:45 UTC
Sorry somehow, did miss this notification of the edit .. will check it and let you know

Comment 9 Gwyn Ciesla 2012-01-26 18:50:57 UTC
Any updates?

Comment 10 Soumya Kanti Chakraborty 2012-01-28 18:22:40 UTC
Some libraries in src/libs appears to be bundled, have to unbundle them and package them separately. Will get back again when its done.

Comment 11 Soumya Kanti Chakraborty 2012-01-30 19:02:48 UTC
This package has few bundled libs and I dont feel so I will have that free time to complete these dependencies and then package pyflag. So dropping it.


Note You need to log in before you can comment on or make changes to this bug.