Bug 757116 - Review Request: perl-JSON-PP-Compat5006 - Helper module in using JSON::PP in Perl 5.6
Summary: Review Request: perl-JSON-PP-Compat5006 - Helper module in using JSON::PP in ...
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-25 14:02 UTC by Petr Pisar
Modified: 2011-11-28 15:24 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-28 15:24:39 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Petr Pisar 2011-11-25 14:02:52 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-JSON-PP-Compat5006/perl-JSON-PP-Compat5006.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-JSON-PP-Compat5006/perl-JSON-PP-Compat5006-1.09-1.fc17.src.rpm
Description: 
JSON::PP calls internally.


This package is needed for ExtUtils-MakeMaker from CPAN.

Comment 1 Ville Skyttä 2011-11-28 14:52:24 UTC
(In reply to comment #0)
> JSON::PP calls internally.

...but only with Perl < 5.8.  I don't think it makes sense to ship this for Fedora - there are no active Fedora or EL releases that would have such an old version of Perl.

http://cpansearch.perl.org/src/MAKAMAKA/JSON-PP-2.27200/lib/JSON/PP.pm

    if ($] < 5.008 ) {
        my $helper = $] >= 5.006 ? 'JSON::PP::Compat5006' : 'JSON::PP::Compat5005';
        eval qq| require $helper |;
        if ($@) { Carp::croak $@; }
    }

Comment 2 Petr Pisar 2011-11-28 15:14:03 UTC
Problem is ExtUtils::MakeMaker detects presence of the module, and if not found, it will use bundled JSON::PP::Compat5006 instead. I will look how to inhibit it.

Comment 3 Petr Pisar 2011-11-28 15:24:39 UTC
So it was not so hard to deal with it.


Note You need to log in before you can comment on or make changes to this bug.