Bug 757851 - (ark) Review Request: ark - Archive manager
Review Request: ark - Archive manager
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Radek Novacek
Fedora Extras Quality Assurance
: 757850 (view as bug list)
Depends On:
Blocks: kde-reviews kde-4.8
  Show dependency treegraph
Reported: 2011-11-28 15:34 EST by Rex Dieter
Modified: 2016-11-30 19:30 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2011-12-15 14:58:43 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rnovacek: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Rex Dieter 2011-11-28 15:34:40 EST
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/ark.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeutils/ark-4.7.80-1.fc16.src.rpm
Ark is a program for managing various archive formats.

Archives can be viewed, extracted, created and modified from within Ark.
The program can handle various formats such as tar, gzip, bzip2, zip,
rar and lha (if appropriate command-line programs are installed).

This is being split out in kde-4.7.80 from previously monolithic kdeutils package.
Comment 1 Rex Dieter 2011-11-28 15:35:19 EST
*** Bug 757850 has been marked as a duplicate of this bug. ***
Comment 2 Radek Novacek 2011-12-15 05:06:46 EST
Name: ok
License: not ok, batchextract.(h|cpp) have BSD license and are compiled to ark binary in main package, so licence should be BSD and GPLv2+ (same as for -libs subpackage)
Source: ok
BRs/Reqs: ok
Macros used consistently: ok
ldconfig: ok
Desktop file validations: ok
Locales: ok
Docs: COPYING should be installed
Devel: NA
Files: ok
Build: ok
rpmlint: no need to fix
ark.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
ark.src: W: spelling-error %description -l en_US rar -> arr, ear, tar
ark.src: W: spelling-error %description -l en_US lha -> la, ha, lea
ark.x86_64: E: script-without-shebang /usr/share/applications/kde4/ark.desktop
ark-libs.x86_64: W: obsolete-not-provided kdeutils-ark-libs
ark-libs.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 1 errors, 11 warnings.

Please, fix the license and docs and this package will be good to go.
Comment 3 Rex Dieter 2011-12-15 07:49:30 EST
I think I disagree with your point about licensing.  Taking BSD + GPLv2+ sources does indeed result in an aggregate binary license that is GPLv2+ (the license: tag in .spec files is intended to track the licensing of packaged binaries, not necessarily track every licence of the sources used).
Comment 4 Radek Novacek 2011-12-15 07:58:04 EST
OK, thanks for explanation, I'm setting fedora-review+. I don't consider missing COPYING as blocker.
Comment 5 Rex Dieter 2011-12-15 08:06:01 EST
Thanks, I'll make sure to add %doc COPYING before issuing any builds

New Package SCM Request
Package Name: ark
Short Description: Archive manager
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f16
Comment 6 Gwyn Ciesla 2011-12-15 08:18:51 EST
Git done (by process-git-requests).
Comment 7 Rex Dieter 2011-12-15 14:58:43 EST

Note You need to log in before you can comment on or make changes to this bug.