Red Hat Bugzilla – Bug 757851
Review Request: ark - Archive manager
Last modified: 2016-11-30 19:30:08 EST
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/ark.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeutils/ark-4.7.80-1.fc16.src.rpm
Ark is a program for managing various archive formats.
Archives can be viewed, extracted, created and modified from within Ark.
The program can handle various formats such as tar, gzip, bzip2, zip,
rar and lha (if appropriate command-line programs are installed).
This is being split out in kde-4.7.80 from previously monolithic kdeutils package.
*** Bug 757850 has been marked as a duplicate of this bug. ***
License: not ok, batchextract.(h|cpp) have BSD license and are compiled to ark binary in main package, so licence should be BSD and GPLv2+ (same as for -libs subpackage)
Macros used consistently: ok
Desktop file validations: ok
Docs: COPYING should be installed
rpmlint: no need to fix
ark.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
ark.src: W: spelling-error %description -l en_US rar -> arr, ear, tar
ark.src: W: spelling-error %description -l en_US lha -> la, ha, lea
ark.x86_64: E: script-without-shebang /usr/share/applications/kde4/ark.desktop
ark-libs.x86_64: W: obsolete-not-provided kdeutils-ark-libs
ark-libs.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 1 errors, 11 warnings.
Please, fix the license and docs and this package will be good to go.
I think I disagree with your point about licensing. Taking BSD + GPLv2+ sources does indeed result in an aggregate binary license that is GPLv2+ (the license: tag in .spec files is intended to track the licensing of packaged binaries, not necessarily track every licence of the sources used).
OK, thanks for explanation, I'm setting fedora-review+. I don't consider missing COPYING as blocker.
Thanks, I'll make sure to add %doc COPYING before issuing any builds
New Package SCM Request
Package Name: ark
Short Description: Archive manager
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Git done (by process-git-requests).