Red Hat Bugzilla – Bug 757866
Review Request: kde-printer-applet - KDE printer applet
Last modified: 2012-01-14 20:38:54 EST
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/printer-applet.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeutils/printer-applet-4.7.80-1.fc16.src.rpm
Printer Applet is a system tray utility that shows current print jobs,
shows printer warnings and errors.
This is being split out in kde-4.7.80 from previously monolithic kdeutils
Starting off here with upstream's 'printer-applet' name, but we probably want to use something less generic, perhaps kde-printer-applet.
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/kde-printer-applet.spec
update to 4.7.90, renamed to kde-printer-applet
I think the .desktop file should be renamed to respect the new package name for consistency (from 'printer-applet.desktop' to 'kde-printer-applet.desktop').
Also, the .spec file is missing the desktop-file-validate step.
I don't think renaming the .desktop file makes sense.
I'll advocate renaming stuff away from being generic, but I'd also argue it's not something that should be considered a review blocker.
make that "being generic... *upstream*"
Agreed, renaming things upstream would make a lot of sense, it's renaming the .desktop file downstream which I don't think is helpful.
+1 to not renaming downstream
Name: ok (make sense to use less generic, upstream it?)
Macros used consistently: ok
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Sources: ok (md5sum b66e859e551a10e09712217b1d160a95)
For desktop file validation - skip this step, it's autorun desktop file, not shown in Kickstart. I didn't realize it, sorry.
New Package SCM Request
Package Name: kde-printer-applet
Short Description: KDE Printer applet
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Git done (by process-git-requests).