Bug 758210 - Review Request: perl-ExtUtils-Manifest - Utilities to write and check a MANIFEST file
Summary: Review Request: perl-ExtUtils-Manifest - Utilities to write and check a MANIF...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-29 14:49 UTC by Petr Pisar
Modified: 2012-01-11 16:28 UTC (History)
2 users (show)

Fixed In Version: perl-ExtUtils-Manifest-1.60-1.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-11 16:28:17 UTC
Type: ---
mmaslano: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2011-11-29 14:49:47 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-ExtUtils-Manifest/perl-ExtUtils-Manifest.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-ExtUtils-Manifest/perl-ExtUtils-Manifest-1.60-1.fc17.src.rpm
Description:
Utilities to write and check a MANIFEST file.


This package will dual-live with sub-package of perl since (perl-5.14.2-205.fc17).

Comment 1 Marcela Mašláňová 2012-01-10 11:20:24 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
http://koji.fedoraproject.org/koji/taskinfo?taskID=3634975
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

APPROVED

Comment 2 Petr Pisar 2012-01-11 13:53:46 UTC
New Package SCM Request
=======================
Package Name: perl-ExtUtils-Manifest 
Short Description: Utilities to write and check a MANIFEST file
Owners: ppisar mmaslano psabata
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2012-01-11 14:28:13 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2012-01-11 16:28:17 UTC
Thank you for the review and repository.


Note You need to log in before you can comment on or make changes to this bug.