Bug 7585 - Patch for /etc/rc.d/init.d/isdn problems
Patch for /etc/rc.d/init.d/isdn problems
Status: CLOSED RAWHIDE
Product: Red Hat Raw Hide
Classification: Retired
Component: isdn4k-utils (Show other bugs)
1.0
i386 Linux
medium Severity high
: ---
: ---
Assigned To: Cristian Gafton
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 1999-12-04 14:59 EST by rossigee
Modified: 2008-05-01 11:37 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2000-02-05 01:53:20 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description rossigee 1999-12-04 14:59:57 EST
Please find attached a patch to the isdn4k-utils-3.0-6 rollup from RawHide.
You managed to fix the typo bug (#5763), but this doesn't appear to have
then been tested fully. There are still a few problems, which this patch
should address.

1) No prior sourcing of the /etc/sysconfig/network file for the system-wide
NETWORKING setting.

2) isdnlog started without the -D option, causing the console to lock up
during startup.

3) the for loop that sources the 'providers' files picks up editor backup
files (~ files) and attempts to configure interfaces for them.

Regards,

--
Ross

--- isdn.orig	Mon Oct 11 16:12:15 1999
+++ isdn	Sat Dec  4 20:40:55 1999
@@ -15,6 +15,8 @@
 # Source function library
 . /etc/rc.d/init.d/functions

+. /etc/sysconfig/network
+
 [ ${NETWORKING} = "no" ] && exit 0
 [ -x /usr/sbin/isdnctrl ] || exit 0
 [ -x /usr/sbin/isdnlog ] || exit 0
@@ -30,13 +32,13 @@
 	hisaxctrl HiSax 1 0x3ff
 	# isdnlog -vw2 -S -m10231 -F -h5:3 -t1 /dev/isdnctrl 2>/var/log/isdn.log
echo -n "Starting isdn logging: "
-	daemon isdnlog -vw2 -S -m10231 -F -t1 /dev/isdnctrl
+	daemon isdnlog -D -vw2 -S -m10231 -F -t1 /dev/isdnctrl
 	RETVAL=$?
 	echo
 	devices=

 	# Loop for each provider...
-	for prov in /etc/sysconfig/provider/conf-*; do
+	for prov in `ls /etc/sysconfig/provider/conf-* | egrep
'conf-[a-z0-9]+$'`; do
 		source $prov
 		# ISDNDEV is either ippp$num_sync or isdn$num_raw
 		if [ "x$ISDNDEV" = "xippp" ]; then
Comment 1 Ronald Bruintjes 1999-12-30 07:53:59 EST
Also, if I understand bash scripting correctly, there is an unreachable section
in setting the default gateway:

if [ "x$ACTIVEPROV" = "x$PROVIDER" -a "x$ART" = "xautomatisch" -a "$ART" =
"automatic" ]; then

As far as I can determine, there's no way that $ART can both be "automatisch"
and "automatic"...
Comment 2 Karsten Hopp 2000-01-07 09:19:59 EST
Fixed in Rawhide and in
ftp://ftp.redhat.de/pub/rh-addons/isdn/testing/i386/*isdn*.rpm

Note You need to log in before you can comment on or make changes to this bug.