Bug 758786 - hardcoded paths in spec
Summary: hardcoded paths in spec
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: tog-pegasus
Version: 5.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Vitezslav Crhonek
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-30 17:39 UTC by Karel Volný
Modified: 2011-12-05 12:15 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-05 12:15:19 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Karel Volný 2011-11-30 17:39:01 UTC
Description of problem:
The specfile has system paths for files hardcoded instead of using macros.

Version-Release number of selected component (if applicable):
tog-pegasus-2.11.0-1.el5

How reproducible:
always

Steps to Reproduce:
1. inspect tog-pegasus-2.11.0-1.el5.src.rpm.spec
  
Actual results:
%files
%defattr(0750, root, pegasus, 0750)
/usr/share/Pegasus/scripts
%defattr(0750, root, pegasus, 0750)
%attr(0755, root, pegasus) /usr/sbin/cimauth
%attr(0755, root, pegasus) /usr/sbin/cimconfig
%attr(0755, root, pegasus) /usr/sbin/cimprovagt
%attr(0755, root, pegasus) /usr/sbin/cimserver
%attr(0755, root, pegasus) /usr/sbin/cimservermain
%attr(0755, root, pegasus) /usr/sbin/cimuser
%attr(0755, root, pegasus) /usr/sbin/repupgrade
%attr(0755, root, pegasus) /usr/sbin/cimreparchive
%attr(0755, root, pegasus) /usr/sbin/cimshutdown
%attr(0755, root, pegasus) /usr/sbin/cimtrust
%attr(0755, root, pegasus) /usr/bin/cimmof
%attr(0755, root, pegasus) /usr/bin/cimmofl
%attr(0755, root, pegasus) /usr/bin/cimprovider
%attr(0755, root, pegasus) /usr/bin/osinfo
%attr(0755, root, pegasus) /usr/bin/wbemexec
%attr(0755, root, pegasus) /usr/bin/cimsub
%attr(0755, root, pegasus) %config(noreplace) /etc/rc.d/init.d/tog-pegasus
%defattr(0640, root, pegasus, 0750)
%dir %attr(755,root,pegasus) /etc/Pegasus
#%ghost %config(noreplace) /etc/Pegasus/cimserver_current.conf
%ghost %config(noreplace) /etc/Pegasus/cimserver_planned.conf
%config(noreplace) /etc/Pegasus/access.conf
%config(noreplace) /etc/pam.d/wbem
%ghost /etc/Pegasus/ssl.cnf
%ghost /etc/Pegasus/client.pem
%ghost /etc/Pegasus/server.pem
%ghost /etc/Pegasus/file.pem
#%ghost /etc/Pegasus/cimserver_trust
#%ghost /etc/Pegasus/indication_trust
#%ghost /etc/Pegasus/crl
%dir %attr(0755, root, pegasus) /var/lib/Pegasus
%defattr(600,cimsrvr,cimsrvr,700)
%verify(not md5 size mtime mode group) /var/lib/Pegasus/repository
%defattr(0640, root, pegasus, 0750)
/var/lib/Pegasus/cache
%dir /var/lib/Pegasus/log
%ghost %verify(not md5 size mtime) /var/lib/Pegasus/log/install.log
#%ghost %verify(not md5 size mtime) /var/lib/Pegasus/cache/trace/cimserver.trc
%dir   %attr(1750,cimsrvr,cimsrvr) /var/run/tog-pegasus
#%ghost /var/run/tog-pegasus/cimserver.pid
#%ghost /var/run/tog-pegasus/cimserver_start.lock
#%ghost %attr(1640,root,pegasus) /var/run/tog-pegasus/cimxml.socket
%defattr(0644, root, pegasus, 0755)
%dir /usr/share/Pegasus
/usr/share/Pegasus/mof
/usr/share/man/man8/*
/usr/share/man/man1/*
%doc doc/license.txt doc/Admin_Guide_Release.pdf doc/PegasusSSLGuidelines.htm doc/SecurityGuidelinesForDevelopers.html doc/README.RedHat.Security src/Clients/repupgrade/doc/repupgrade.html doc/README.RedHat.SSL

%files devel
%defattr(0644,root,pegasus,0755)
/usr/include/Pegasus
/usr/share/Pegasus/samples
/usr/share/Pegasus/html

%if %{PEGASUS_BUILD_TEST_RPM}
%files test -f ghost_arch_test
%defattr(0644,root,pegasus,0755)
%dir /usr/share/Pegasus/test
/usr/share/Pegasus/test/Makefile%{bsx}
/usr/share/Pegasus/test/mak
%verify(not md5 size mtime) /var/lib/Pegasus/testrepository
%defattr(0750,root,pegasus,0755)
/usr/share/Pegasus/test/bin
/usr/share/Pegasus/test/lib
%endif

%files libs
%defattr(0755, root, pegasus, 0750)
%attr(755,root,pegasus) /usr/%{_lib}/Pegasus
%attr(755,root,pegasus) /usr/%{_lib}/Pegasus/providers
%attr(755,root,pegasus) /usr/%{_lib}/Pegasus/providerManagers
%attr(755,root,pegasus) /usr/%{_lib}/*.so
%attr(755,root,pegasus) /usr/%{_lib}/*.so.1
#%attr(755,root,pegasus) /usr/%{_lib}/Pegasus/providerManagers/*.so.1
%if %{PEGASUS_32BIT_PROVIDER_SUPPORT}
%defattr(0755, root, pegasus, 0750)
%dir /usr/lib/Pegasus
%dir /usr/lib/Pegasus/providers
%dir /usr/lib/Pegasus/providerManagers
%attr(755,root,pegasus) /usr/lib/*.so.1
%attr(755,root,pegasus) /usr/lib/Pegasus/providerManagers/*.so.1
/usr/lib/libpegclient.so
/usr/lib/libpegcommon.so
/usr/lib/libpegprovider.so
/usr/lib/libDefaultProviderManager.so
/usr/lib/Pegasus/providerManagers/libCMPIProviderManager.so
%endif
%if !%{NODEBUGINFO}
%exclude /usr/lib/debug
%endif


Expected results:
%files
%defattr(0750, root, pegasus, 0750)
%{_datadir}/Pegasus/scripts
%defattr(0750, root, pegasus, 0750)
%attr(0755, root, pegasus) %{_sbindir}/cimauth
%attr(0755, root, pegasus) %{_sbindir}/cimconfig
%attr(0755, root, pegasus) %{_sbindir}/cimprovagt
%attr(0755, root, pegasus) %{_sbindir}/cimserver
%attr(0755, root, pegasus) %{_sbindir}/cimservermain
%attr(0755, root, pegasus) %{_sbindir}/cimuser
%attr(0755, root, pegasus) %{_sbindir}/repupgrade
%attr(0755, root, pegasus) %{_sbindir}/cimreparchive
%attr(0755, root, pegasus) %{_sbindir}/cimshutdown
%attr(0755, root, pegasus) %{_sbindir}/cimtrust
%attr(0755, root, pegasus) %{_bindir}/cimmof
%attr(0755, root, pegasus) %{_bindir}/cimmofl
%attr(0755, root, pegasus) %{_bindir}/cimprovider
%attr(0755, root, pegasus) %{_bindir}/osinfo
%attr(0755, root, pegasus) %{_bindir}/wbemexec
%attr(0755, root, pegasus) %{_bindir}/cimsub
%attr(0755, root, pegasus) %config(noreplace) %{_initddir}/tog-pegasus
%defattr(0640, root, pegasus, 0750)
%dir %attr(755,root,pegasus) %{_sysconfdir}/Pegasus
#%ghost %config(noreplace) %{_sysconfdir}/Pegasus/cimserver_current.conf
%ghost %config(noreplace) %{_sysconfdir}/Pegasus/cimserver_planned.conf
%config(noreplace) %{_sysconfdir}/Pegasus/access.conf
%config(noreplace) %{_sysconfdir}/pam.d/wbem
%ghost %{_sysconfdir}/Pegasus/ssl.cnf
%ghost %{_sysconfdir}/Pegasus/client.pem
%ghost %{_sysconfdir}/Pegasus/server.pem
%ghost %{_sysconfdir}/Pegasus/file.pem
#%ghost /etc/Pegasus/cimserver_trust
#%ghost /etc/Pegasus/indication_trust
#%ghost /etc/Pegasus/crl
%dir %attr(0755, root, pegasus) %{_sharedstatedir}/Pegasus
%defattr(600,cimsrvr,cimsrvr,700)
%verify(not md5 size mtime mode group) %{_sharedstatedir}/Pegasus/repository
%defattr(0640, root, pegasus, 0750)
%{_sharedstatedir}/Pegasus/cache
%dir %{_sharedstatedir}/Pegasus/log
%ghost %verify(not md5 size mtime) %{_sharedstatedir}/Pegasus/log/install.log
#%ghost %verify(not md5 size mtime) /var/lib/Pegasus/cache/trace/cimserver.trc
%dir   %attr(1750,cimsrvr,cimsrvr) %{_localstatedir}/run/tog-pegasus
#%ghost /var/run/tog-pegasus/cimserver.pid
#%ghost /var/run/tog-pegasus/cimserver_start.lock
#%ghost %attr(1640,root,pegasus) /var/run/tog-pegasus/cimxml.socket
%defattr(0644, root, pegasus, 0755)
%dir %{_datarootdir}/Pegasus
%{_datarootdir}/Pegasus/mof
%{_mandir}/man8/*
%{_mandir}/man1/*
%doc doc/license.txt doc/Admin_Guide_Release.pdf doc/PegasusSSLGuidelines.htm doc/SecurityGuidelinesForDevelopers.html doc/README.RedHat.Security src/Clients/repupgrade/doc/repupgrade.html doc/README.RedHat.SSL

%files devel
%defattr(0644,root,pegasus,0755)
%{_includedir}/Pegasus
%{_datarootdir}/Pegasus/samples
%{_datarootdir}/Pegasus/html

%if %{PEGASUS_BUILD_TEST_RPM}
%files test -f ghost_arch_test
%defattr(0644,root,pegasus,0755)
%dir %{_datarootdir}/Pegasus/test
%{_datarootdir}/Pegasus/test/Makefile%{bsx}
%{_datarootdir}/Pegasus/test/mak
%verify(not md5 size mtime) %{_sharedstatedir}/Pegasus/testrepository
%defattr(0750,root,pegasus,0755)
%{_datarootdir}/Pegasus/test/bin
%{_datarootdir}/Pegasus/test/lib
%endif

%files libs
%defattr(0755, root, pegasus, 0750)
%attr(755,root,pegasus) %{_libdir}/Pegasus
%attr(755,root,pegasus) %{_libdir}/Pegasus/providers
%attr(755,root,pegasus) %{_libdir}/Pegasus/providerManagers
%attr(755,root,pegasus) %{_libdir}/*.so
%attr(755,root,pegasus) %{_libdir}/*.so.1
#%attr(755,root,pegasus) /usr/%{_lib}/Pegasus/providerManagers/*.so.1
%if %{PEGASUS_32BIT_PROVIDER_SUPPORT}
%defattr(0755, root, pegasus, 0750)
%dir %{_exec_prefix}/lib/Pegasus
%dir %{_exec_prefix}/lib/Pegasus/providers
%dir %{_exec_prefix}/lib/Pegasus/providerManagers
%attr(755,root,pegasus) %{_exec_prefix}/lib/*.so.1
%attr(755,root,pegasus) %{_exec_prefix}/lib/Pegasus/providerManagers/*.so.1
%{_exec_prefix}/lib/libpegclient.so
%{_exec_prefix}/lib/libpegcommon.so
%{_exec_prefix}/lib/libpegprovider.so
%{_exec_prefix}/lib/libDefaultProviderManager.so
%{_exec_prefix}/lib/Pegasus/providerManagers/libCMPIProviderManager.so
%endif
%if !%{NODEBUGINFO}
%exclude %{_exec_prefix}/lib/debug
%endif


Additional info:
please see http://fedoraproject.org/wiki/Packaging:RPMMacros

note that some /lib/ path elements cannot be replaced due to 32bit content even on 64bit systems (there's no {_%lib} macro variant that wouldn't expand to "lib64" on 64bit system)

see also https://errata.devel.redhat.com/rpmdiff/show/54927?result_id=912962

Comment 2 RHEL Program Management 2011-12-05 12:15:19 UTC
Development Management has reviewed and declined this request.  You may appeal
this decision by reopening this request.


Note You need to log in before you can comment on or make changes to this bug.