Bug 758966 - (ghc-warp) Review Request: ghc-warp - Fast webserver library for WAI apps
Review Request: ghc-warp - Fast webserver library for WAI apps
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Narasimhan
Fedora Extras Quality Assurance
Depends On: ghc-simple-sendfile
Blocks: 630303
  Show dependency treegraph
Reported: 2011-11-30 23:58 EST by Jens Petersen
Modified: 2012-02-07 03:26 EST (History)
4 users (show)

See Also:
Fixed In Version: ghc-warp-
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-02-07 02:52:13 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lakshminaras2002: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Jens Petersen 2011-11-30 23:58:55 EST
Spec URL: http://petersen.fedorapeople.org/reviews/ghc-warp/ghc-warp.spec
SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-warp/ghc-warp-
Warp is a highly performant web server library for Haskell.
It is used by Yesod, Mighttpd and some other apps and frameworks.


There have been performance benchmarks with ghc7 on par with nginx
or even better using when using pre-fork concurrency for example.
Comment 3 Narasimhan 2012-01-22 01:21:19 EST
[+]MUST: rpmlint must be run on every package. The output should be posted in the review.

rpmlint  -i ghc-warp- ghc-warp-  ghc-warp-devel-  ../ghc-warp.spec 
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Version-release - Matches
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK, in devel package

[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual license.
BSD license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
LICENSE file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.
 md5sum warp- 
e9f232303445224b28184b1bfb5eedad  warp-

md5sum ghc-warp- 
e9f232303445224b28184b1bfb5eedad  ghc-warp-

[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
API documentation is in -devel package
[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}
rpm -e ghc-warp
error: Failed dependencies:
        ghc(warp- = 4a882afc5ec83d107d700af68bd33bf0 is needed by (installed) ghc-warp-devel-
        ghc-warp = is needed by (installed) ghc-warp-devel-

[NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section
[+]MUST: Packages must not own files or directories already owned by other packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installed the packages. Loaded Network.Wai.Handler.Warp into ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.
[+]SHOULD: License header is mentioned in each source file.

cabal2spec-diff is OK.


Latest version is 1.0.
Comment 4 Jens Petersen 2012-01-22 22:22:30 EST
Thank you for reviewing.

Yes, will to 1.0 later when new dependencies are packaged. :)

New Package SCM Request
Package Name: ghc-warp
Short Description: Fast webserver library for WAI apps
Owners: petersen
Branches: f16 f15 el6
InitialCC: haskell-sig
Comment 5 Gwyn Ciesla 2012-01-23 08:05:59 EST
Git done (by process-git-requests).
Comment 6 Jens Petersen 2012-01-23 22:27:16 EST
Built for F17 rawhide
Comment 7 Fedora Update System 2012-01-25 04:36:50 EST
ghc-case-insensitive-,ghc-http-types-0.6.8-1.fc16.1,ghc-snap-core-,ghc-wai-0.4.3-1.fc16,ghc-wai-extra-,ghc-warp- has been submitted as an update for Fedora 16.
Comment 8 Fedora Update System 2012-01-25 17:29:49 EST
ghc-case-insensitive-, ghc-http-types-0.6.8-1.fc16.1, ghc-snap-core-, ghc-wai-0.4.3-1.fc16, ghc-wai-extra-, ghc-warp- has been pushed to the Fedora 16 testing repository.
Comment 9 Fedora Update System 2012-01-25 19:43:11 EST
ghc-warp- has been submitted as an update for Fedora 15.
Comment 10 Fedora Update System 2012-02-07 02:52:13 EST
ghc-warp- has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2012-02-07 02:57:28 EST
ghc-case-insensitive-, ghc-http-types-0.6.8-1.fc16.1, ghc-snap-core-, ghc-wai-0.4.3-1.fc16, ghc-wai-extra-, ghc-warp- has been pushed to the Fedora 16 stable repository.

Note You need to log in before you can comment on or make changes to this bug.