Bug 759615 - detected duplicate packages in multiple jars
Summary: detected duplicate packages in multiple jars
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: No Component
Version: 4.2
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
: RHQ 4.4.0
Assignee: John Mazzitelli
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-02 20:52 UTC by John Mazzitelli
Modified: 2013-09-01 10:01 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-09-01 10:01:09 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 794503 0 high CLOSED Ensure all JON jar files are *NOT* signed and that there are no unintended consequences of that 2021-02-22 00:41:40 UTC

Internal Links: 794503

Description John Mazzitelli 2011-12-02 20:52:26 UTC
I ran my duplicate package detector utility on the lib/ directory of the CLI and the agent lib/ directory (as built in master) and got the following results. We need to look into possibly refactoring the code so the same package is not specified in two or more .jar files to avoid class loading issues when the jars are signed.

$ java -cp ~/source/rhq/modules/test-utils/target/test-utils-4.3.0-SNAPSHOT.jar org.rhq.test.DuplicatePackagesDetector ~/source/rhq/modules/enterprise/remoting/cli/target/rhq-remoting-cli-4.3.0-SNAPSHOT/lib
======================================================================
org/rhq/core/server
        rhq-core-domain-4.3.0-SNAPSHOT.jar
        rhq-enterprise-server-4.3.0-SNAPSHOT-client.jar

$ java -cp ~/source/rhq/modules/test-utils/target/test-utils-4.3.0-SNAPSHOT.jar org.rhq.test.DuplicatePackagesDetector ~/source/rhq/modules/enterprise/agent/target/rhq-agent/lib
======================================================================
org/rhq/core/clientapi/util
        rhq-core-client-api-4.3.0-SNAPSHOT.jar
        rhq-core-util-4.3.0-SNAPSHOT.jar

Comment 1 John Mazzitelli 2012-03-29 20:37:07 UTC
those duplicate packages (at least as seen in all the CLI jars) are still there:

org/rhq/core/server
        rhq-core-domain-4.4.0-SNAPSHOT.jar
        rhq-enterprise-server-4.4.0-SNAPSHOT-client.jar

which is potentially why bug #794503 is still happening.

Comment 2 John Mazzitelli 2012-03-30 19:03:47 UTC
master commits:

b0bcb5d6f5ef3f3c28e00a2bee24e3e0599de525 - refactor domain jar's org.rhq.core.server package to org.rhq.core.domain.server

3266294b4768113f529df1d77b03e056579389e5 - generates classes in a unique package name (this was for bug #794503)

bb92f0d2bf0ab28e71c775b8b3abef3adc5ff864 - moves the StringUtil from org.rhq.core.clientapi.util package (as found in core/util module) to org.rhq.core.util

Comment 3 Mike Foley 2012-03-30 19:22:43 UTC
QE: this needs to be verified in a JON Brew build ... (ie, not Jenkins)

Comment 4 Heiko W. Rupp 2013-09-01 10:01:09 UTC
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.


Note You need to log in before you can comment on or make changes to this bug.