Hide Forgot
Spec URL: http://thm.fedorapeople.org/xcb-util-wm/xcb-util-wm.spec SRPM URL: http://thm.fedorapeople.org/xcb-util-wm/xcb-util-wm-0.3.8-1.fc16.src.rpm Description: XCB util-wm module provides the following libraries: - ewmh: Both client and window-manager helpers for EWMH. - icccm: Both client and window-manager helpers for ICCCM. Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3563676
Review ======= There are some minor cleanups you can make like: * drop rm -rf %{buildroot} from %install * drop default defattr lines * drop BuildRoot line * Use %{name}%{?_isa} instead of just %{name} in explicit Requires: * Fix the devel description (s/xcb-utilwm/xcb-util-wm). But all of those are minor. Just consider making those changes before committing. Good: - rpmlint checks return: xcb-util-wm.src: W: spelling-error Summary(en_US) libxcb -> Libby xcb-util-wm.src: W: spelling-error %description -l en_US ewmh -> whew xcb-util-wm.src: W: spelling-error %description -l en_US icccm -> ICC xcb-util-wm.x86_64: W: spelling-error Summary(en_US) libxcb -> Libby xcb-util-wm.x86_64: W: spelling-error %description -l en_US ewmh -> whew xcb-util-wm.x86_64: W: spelling-error %description -l en_US icccm -> ICC xcb-util-wm-devel.x86_64: W: spelling-error Summary(en_US) vm -> cm, v, m xcb-util-wm-devel.x86_64: W: spelling-error %description -l en_US utilwm -> utility All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r APPROVED.
Thanks for the review spot! New Package SCM Request ======================= Package Name: xcb-util-wm Short Description: Client and window-manager helper library on top of libxcb Owners: thm Branches: f17 InitialCC:
Git done (by process-git-requests).
xcb-util-wm-0.3.8-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xcb-util-wm-0.3.8-2.fc17
xcb-util-wm-0.3.8-2.fc17 has been pushed to the Fedora 17 testing repository.
xcb-util-wm-0.3.8-2.fc17 has been pushed to the Fedora 17 stable repository.