Bug 760155 - Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb
Summary: Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage function...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-05 14:42 UTC by Thomas Moschny
Modified: 2012-04-14 04:29 UTC (History)
3 users (show)

Fixed In Version: xcb-util-image-0.3.8-2.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-04-14 04:29:43 UTC
Type: ---
Embargoed:
tcallawa: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Thomas Moschny 2011-12-05 14:42:42 UTC
Spec URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image.spec
SRPM URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image-0.3.8-1.fc16.src.rpm
Description:
XCB util-image module provides the following library:

  - image: Port of Xlib's XImage and XShmImage functions.

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3563741

Comment 1 Thomas Moschny 2012-04-05 14:39:52 UTC
Spec URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image.spec
SRPM URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image-0.3.8-2.fc18.src.rpm

Spec file updates:
- Drop BR on pkgconfig
- Drop BuildRoot tag
- Drop defattr lines
- Use %{_isa} in explicit dependency
- Remove chrpath, seems unnecessary

Comment 2 Tom "spot" Callaway 2012-04-05 14:57:35 UTC
Review
=======

- rpmlint checks return:

xcb-util-image.src: W: spelling-error Summary(en_US) libxcb -> Libby
xcb-util-image.x86_64: W: spelling-error Summary(en_US) libxcb -> Libby
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

APPROVED.

Comment 3 Thomas Moschny 2012-04-05 15:28:05 UTC
Thanks for the review, spot!

New Package SCM Request
=======================
Package Name: xcb-util-image
Short Description: Port of Xlib's XImage and XShmImage functions on top of libxcb
Owners: thm
Branches: f17
InitialCC:

Comment 4 Gwyn Ciesla 2012-04-05 16:11:52 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2012-04-05 22:25:12 UTC
xcb-util-image-0.3.8-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/xcb-util-image-0.3.8-2.fc17

Comment 6 Fedora Update System 2012-04-06 23:23:43 UTC
xcb-util-image-0.3.8-2.fc17 has been pushed to the Fedora 17 testing repository.

Comment 7 Fedora Update System 2012-04-14 04:29:43 UTC
xcb-util-image-0.3.8-2.fc17 has been pushed to the Fedora 17 stable repository.


Note You need to log in before you can comment on or make changes to this bug.