Bug 760491 - anniversaries not displayed in calendar properly
Summary: anniversaries not displayed in calendar properly
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: evolution
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Matthew Barnes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-06 10:35 UTC by arturj
Modified: 2011-12-13 12:31 UTC (History)
4 users (show)

Fixed In Version: evolution-data-server-3.2.3
Clone Of:
Environment:
Last Closed: 2011-12-13 12:28:09 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
new contact just created and fully working (498 bytes, text/vcard)
2011-12-08 11:55 UTC, arturj
no flags Details
contact after beeing synced to server, deleted locally and synced back to client (428 bytes, text/vcard)
2011-12-08 11:55 UTC, arturj
no flags Details
contect view - missing header after syncing back to client (4.87 KB, image/png)
2011-12-08 11:56 UTC, arturj
no flags Details
contact details view - grayed-out OK button even after changing data (49.14 KB, image/png)
2011-12-08 11:57 UTC, arturj
no flags Details

Description arturj 2011-12-06 10:35:22 UTC
Description of problem:
After creating a new addressbook with use for anniversaries property and entering some test data with e.g. birthdays these are not displayed in the calender view. This started after update to fedora 16

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. create new addressbook with use for anniversaries property enabled
2. enter some test data with birthday
3. switch to calndar view and check anniversaries calender is enabled
  
Actual results:
anniversaries are not displayed

Expected results:
anniversaries are displayed

Additional info:
For a new addressbook filled with just some fresh test data I could fix this by disabling and re-enabling the use for anniversaries property of that addressbook.

For an existing addressbook filled by syncevolution I was not able to apply the same fix - still no anniversaries in my calendar.

Comment 1 Milan Crha 2011-12-07 09:10:24 UTC
Thanks for a bug report. This seems to be better dealt with upstream, but let's try to investigate a bit before we move there. I found similar-sounded bug [1] there, thus please, could you check whether the contact has set the Birthday date properly, please? Also, there is significant where the address book is stored, regardless of the checkbox for the availability of the addressbook in the calendar, unfortunately, but I suppose you synchronize your addressbook with a new one under On This Computer node?

[1] https://bugzilla.gnome.org/show_bug.cgi?id=568003

Comment 2 arturj 2011-12-07 11:13:12 UTC
All synced birthdays are correct - no drift at all, but I noticed the following:

Most of the synced entries have an grayed-out "OK" button when I edit them - even after editing some details, so I can't save changes! But I still can press ENTER so close the edit-dialog and save changes! Doing this the entries get kinda updated (see table below) and are now displayed correctly in both the addressbook-view and calendar view. 

Also noticed the following saving the addressbook to an vCard file:
All synced Birthdays are stored as "BDAY: YYYYMMDD", but after updating them they are stored as "BDAY:YYYY-MM-DD" - so theres an difference although in evolution all Birthdays are displayed correctly!

Heres a summary:

View        | Before Update          | After Update
Addressbook | Contact-Header empty   | Header not filled with Name
Calendar    | Birthday not displayed | Birthday displayed
vCard       | BDAY:YYYYMMDD          | BDAY:YYYY-MM-DD

What sill remains is the grayed-out "OK" Button. I also noticed that since update to Fedora 16 Syncevolution only contains addressbook and appointments (missing tasks and notes - why?)

Comment 3 arturj 2011-12-07 11:15:06 UTC
(In reply to comment #1)
> Thanks for a bug report. This seems to be better dealt with upstream, but let's
> try to investigate a bit before we move there. I found similar-sounded bug [1]
> there, thus please, could you check whether the contact has set the Birthday
> date properly, please? Also, there is significant where the address book is
> stored, regardless of the checkbox for the availability of the addressbook in
> the calendar, unfortunately, but I suppose you synchronize your addressbook
> with a new one under On This Computer node?
> 
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=568003

Date is set properly - yes.
No, syncevolution chooses the personal addressbook per default for syncing.

Comment 4 arturj 2011-12-07 11:29:53 UTC
After pushing all updated entries to my funambol sync server and then pulling them again to my fedora client everything is messed up again - syncevolution seems to got incompatible to evolution since fedora 16!

Comment 5 Milan Crha 2011-12-07 11:48:19 UTC
Thanks for the update. I'll ask a syncevolution expert for his thoughts, maybe he will know better (the syncevolution is a 3rd party project, not being done by evolution developers).

It will be good if you could get a sample vcard as a file, some kind of a test contact, which exhibits both issue, not available OK button and same not showing birthday data. I would like to see complete raw data being involved here.

By the way, what if you'll change name or email on the contact, will it enable the OK button in the contact editor?

Comment 6 arturj 2011-12-07 12:35:24 UTC
(In reply to comment #5)
> Thanks for the update. I'll ask a syncevolution expert for his thoughts, maybe
> he will know better (the syncevolution is a 3rd party project, not being done
> by evolution developers).
> 
> It will be good if you could get a sample vcard as a file, some kind of a test
> contact, which exhibits both issue, not available OK button and same not
> showing birthday data. I would like to see complete raw data being involved
> here.
> 
> By the way, what if you'll change name or email on the contact, will it enable
> the OK button in the contact editor?

Thank you, I realy hope that we can sort out this issue. Like stated above "Most of the synced entries have an grayed-out "OK" button when I edit them -
even after editing some details, so I can't save changes!" - NO it will NOT enable the button - you just can press enter which still updates the item!

Comment 7 Milan Crha 2011-12-07 21:18:12 UTC
Thanks for the update. I asked the upstream developer and he told me that he doesn't recall anything similar seeing earlier.

Thus let's start with something simple: please create a test contact, pass it through the syncevolution forth and back, make sure you will be able to reproduce the issue with it, then save it as a vCard, import it back to evolution, ensure it's still doing trouble even on the newly imported contact, and then upload the original vCard file here, so I'll be able to test on my machine and environment. In case you'll not be able to reproduce it after import nothing wrong happened, we'll only fine-tune the steps and extract the vCard data from a database directly (or with gdb). Thanks in advance.

Comment 8 arturj 2011-12-08 11:55:07 UTC
Created attachment 542490 [details]
new contact just created and fully working

Comment 9 arturj 2011-12-08 11:55:52 UTC
Created attachment 542491 [details]
contact after beeing synced to server, deleted locally and synced back to client

Comment 10 arturj 2011-12-08 11:56:40 UTC
Created attachment 542492 [details]
contect view - missing header after syncing back to client

Comment 11 arturj 2011-12-08 11:57:40 UTC
Created attachment 542493 [details]
contact details view - grayed-out OK button even after changing data

Comment 12 arturj 2011-12-08 16:33:58 UTC
(In reply to comment #7)
> Thanks for the update. I asked the upstream developer and he told me that he
> doesn't recall anything similar seeing earlier.

Syncing stoped working like described an all my three fedora 16 clients including both 32 and 64bit OSes. Worked fine before. I also tried different syncevolution versions from official syncevolution-rpm-repo and all I testeed have the same problem: so something must have changed on evolution-side?

Comment 13 Milan Crha 2011-12-13 09:28:32 UTC
Thanks for the update and data. I see that your observation from comment #2 is correct, the File under or Company fields are mandatory, same as Full Name field, and that's a reason why you cannot click on OK to save the changes when the File Under field is empty. The generated contact from syncevolution contains attribute X-EVOLUTION-FILE-AS, but it's empty. I'll move this part upstream. The contact header says it's generated from SyncML Engine V3.4.0.27.

The same is an issue with the Birthdays&Anniversaries calendar, it also requires the File under field being filled, together with either birthday or anniversary fields. Any contacts not satisfying this criterion are ignored. It makes sense, I believe.

To summarize the syncevolution should always populate X-EVOLUTION-FILE-AS field, instead of leaving it empty (I believe it knows about that field, because otherwise it would not be in the vCard). With that fixed everything else in evolution will start working again.

Comment 14 Milan Crha 2011-12-13 12:28:09 UTC
After a chat with Patrick Ohly, whom found a regression in the evolution-data-server code, I made a change to it and committed for the next stable and development release. See [1] for more information. The next synchronization should fix the issue file-as field population.

I also committed fix for the Contacts calendar to pick contact description also from other fields, than only from the file-as, thus your contacts already synced will be part of the calendar with the fix included. It'll be in 3.2.3 and 3.3.3 of evolution-data-server (commit 302e010 and commit 9341f35).

[1] https://bugzilla.gnome.org/show_bug.cgi?id=652173#c18

Comment 15 Patrick Ohly 2011-12-13 12:31:05 UTC
> [Fix] be in 3.2.3
> and 3.3.3 of evolution-data-server (commit 302e010 and commit 9341f35).

In the meantime it might help to update SyncEvolution to the latest stable
version, 1.2. You can download .rpms from syncevolution.org. That version no
longer creates an empty X-EVOLUTION-FILE-AS if it doesn't have a value for it.


Note You need to log in before you can comment on or make changes to this bug.