Bug 761347 – Return value error on the function cmdDomIfGetLink

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 761347 - Return value error on the function cmdDomIfGetLink

Summary:	Return value error on the function cmdDomIfGetLink

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	libvirt (Show other bugs)
Sub Component:
Version:	6.3
Hardware:	x86_64 Linux

Priority	medium Severity medium
Target Milestone:	rc
Target Release:	---
Assigned To:	Alex Jia
QA Contact:	Virtualization Bugs
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-08 01:35 EST by Alex Jia
Modified:	2013-03-22 04:43 EDT (History)
CC List:	9 users (show)

See Also:
Fixed In Version:	libvirt-0.9.9-1.el6
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2012-06-20 02:38:16 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2012:0748	normal	SHIPPED_LIVE	Low: libvirt security, bug fix, and enhancement update	2012-06-19 15:31:38 EDT

Groups: None (edit)

Description Alex Jia 2011-12-08 01:35:40 EST

Description of problem:
Although finding interface with matching mac addr, the return is still '1'.

Version-Release number of selected component (if applicable):
libvirt-0.9.8-0rc2.el6.x86_64

How reproducible:
always.

Steps to Reproduce:
1. virsh domif-getlink <guest name> <interface mac>
2. echo $?
  
Actual results:
# virsh domif-getlink vr-rhel6u2-x86_64-kvm 52:54:00:2f:c4:5d
52:54:00:2f:c4:5d default

# echo $?
1


Expected results:
return 0 when the result is right.

Additional info:

Comment 1 Alex Jia 2011-12-08 01:37:17 EST

Patch for upstream:

https://www.redhat.com/archives/libvir-list/2011-December/msg00378.html

Comment 2 Alex Jia 2011-12-09 09:54:35 EST

Patch has been ACKed and pushed on upstream.

commit 623562964867a4e1927cacb97aa895219e02ccfc
Author: Peter Krempa <pkrempa@redhat.com>
Date:   Thu Dec 8 10:09:59 2011 +0100

    virsh: return correct value from cmdDomIfGetLink
    
    Reported by Alex Jia <ajia@redhat.com>. Function cmdDomIfGetLink did not
    set a success return value on success path.
    
    Signed-off-by: Alex Jia<ajia@redhat.com>

Comment 3 zhpeng 2011-12-13 05:03:26 EST

I test with libvirt-0.9.8-1.el6.x86_64, the same issue.

Comment 5 xhu 2012-01-10 03:24:24 EST

Roproduce it with libvirt-0.9.8-0rc2.el6.x86_64.
Verify it with libvirt-0.9.9-1.el6 and it passed.

Comment 7 errata-xmlrpc 2012-06-20 02:38:16 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html

Note You need to log in before you can comment on or make changes to this bug.