Bug 761474 - Review Request: ibus-european-table - Predictive text for european languages
Summary: Review Request: ibus-european-table - Predictive text for european languages
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-08 11:51 UTC by anish
Modified: 2015-04-12 23:11 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-02-07 06:21:22 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description anish 2011-12-08 11:51:38 UTC
Spec URL:https://github.com/gnuman/fedora_package/blob/master/ibus-european-table.spec
SRPM URL: https://github.com/gnuman/fedora_package/blob/master/ibus-european-table-1.1.0-1.fc15.src.rpm

Description:
 The ibus-european-table predict the text so that typing makes easy for
 user

Comment 1 Parag AN(पराग) 2011-12-14 10:11:52 UTC
Review:

+ koji scratch build f17 ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3583991

+ rpmlint on rpms gave
ibus-european-table.src: W: file-size-mismatch ibus-european-table-1.1.0.tar.gz = 275240, https://github.com/gnuman/fedora_package/blob/master/ibus-european-table-1.1.0.tar.gz = 25090
ibus-european-table.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/ibus-european-table.pc
ibus-european-table.noarch: W: no-manual-page-for-binary ibus-european-table-createdb
ibus-european-table.src: W: file-size-mismatch ibus-european-table-1.1.0.tar.gz = 275240, https://github.com/gnuman/fedora_package/blob/master/ibus-european-table-1.1.0.tar.gz = 25090
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
==> I see that if source is downloaded using wget then size mismatch happens.you can optionally just put the name of tarball instead of URL.

+ Source verified with upstream as 
00ef1ef876878ac03c3978d7f1ec75f3df287907  ibus-european-table-1.1.0.tar.gz
00ef1ef876878ac03c3978d7f1ec75f3df287907  ../SOURCES/ibus-european-table-1.1.0.tar.gz


Suggestions:
1) you don't need to write following line in spec now in Fedora
%defattr(-,root,root,-)

APPROVED.

Comment 2 anish 2011-12-15 05:10:35 UTC
Thanks Parag for the review

Comment 3 anish 2011-12-15 05:14:35 UTC
New Package SCM Request
=======================
Package Name: ibus-european-table
Short Description: Predictive text for european languages 
Owners: anishpatil
Branches: f17,master
InitialCC: apatil@redhat.com

Comment 4 Gwyn Ciesla 2011-12-15 13:15:04 UTC
Git done (by process-git-requests).

f17==devel, and email addresses!= FAS accounts.

Comment 5 anish 2012-01-04 06:41:08 UTC
New Package SCM Request
=======================
Package Name: ibus-european-table
Short Description: Predictive text for european languages 
Owners: anishpatil
Branches: f16,master

Comment 6 anish 2012-01-04 07:09:22 UTC
New Package SCM Request
=======================
Package Name: ibus-european-table
Short Description: Predictive text for european languages 
Owners: anishpatil
Branches: f16
InitialCC:

Comment 7 Gwyn Ciesla 2012-01-04 13:46:42 UTC
This is already done.

Comment 8 Parag AN(पराग) 2012-01-04 14:20:45 UTC
I see only master as a heads. See->http://pkgs.fedoraproject.org/gitweb/?p=ibus-european-table.git

I think you got confused with anish's repeated requests. He is still learning to SCM requests. Please add f16 branch for this package.

Comment 9 anish 2012-01-04 14:43:53 UTC
Thanks Parag and Jon Ciesla.

Jon Ciesla , please  add f16 branch for this package.

Comment 10 Gwyn Ciesla 2012-01-04 14:47:52 UTC
File a package change request:

https://fedoraproject.org/wiki/Package_SCM_admin_requests

Comment 11 anish 2012-01-05 13:02:12 UTC
Package Change Request
======================
Package Name: ibus-european-table
New Branches: f16
Owners: anishpatil
InitialCC:

Comment 12 Gwyn Ciesla 2012-01-05 14:21:30 UTC
Git done (by process-git-requests).

Comment 13 anish 2012-01-06 06:40:16 UTC
Package Change Request
======================
Package Name: ibus-european-table
New Branches: f15
Owners: anishpatil
InitialCC:i18n-team

Comment 14 Gwyn Ciesla 2012-01-06 14:23:23 UTC
Git done (by process-git-requests).

Comment 15 Parag AN(पराग) 2012-01-16 13:32:59 UTC
if the packages are built on koji then submit the update in bodhi.

Comment 16 anish 2012-02-07 06:21:01 UTC
The package is build in koji hence closing the bug


Note You need to log in before you can comment on or make changes to this bug.