Bug 762055 (GLUSTER-323) - fd leak with quick-read loaded in translator tree
Summary: fd leak with quick-read loaded in translator tree
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-323
Product: GlusterFS
Classification: Community
Component: quick-read
Version: mainline
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Raghavendra G
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-15 14:04 UTC by Raghavendra G
Modified: 2009-11-23 09:34 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: RTNR
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Anand Avati 2009-10-15 13:19:23 UTC 
PATCH: http://patches.gluster.com/patch/1917 in master (performance/quick-read: frame->local need not be set in qr_open_cbk.)
Comment 1 Anand Avati 2009-10-15 13:19:31 UTC 
PATCH: http://patches.gluster.com/patch/1918 in release-2.0 (performance/quick-read: frame->local need not be set in qr_open_cbk.)
Comment 2 Raghavendra G 2009-10-15 14:04:33 UTC 
A kernel compile can result in the number of opened files in a system crossing the system limit.

qr_open_cbk checks for frame->local and if it is NULL, it sets op_ret = -1. And with op_ret = -1 the file is not marked as opened. Since many fops does not allocate frame->local, the opens sent by these fops does not mark the file to be opened though open is successful at posix. Hence multiple opens are sent on same fd and since only one release is called per fd, there is fd leak.
Note You need to log in before you can comment on or make changes to this bug.