Bug 762561 (GLUSTER-829) - SETATTR stack leak?
Summary: SETATTR stack leak?
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-829
Product: GlusterFS
Classification: Community
Component: fuse
Version: mainline
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Csaba Henk
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-04-18 23:26 UTC by Krishna Srinivas
Modified: 2015-12-01 16:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)

Description Krishna Srinivas 2010-04-18 23:26:28 UTC
glusterdump had:
[global.callpool]
global.callpool=0x10ef1310
global.callpool.cnt=352

all the 352 calls were SETATTR

looking at the code, when truncate is combined with any other operation in the same SETATTR call, it looks like there is a stack leak.

fuse_setattr_cbk():


                if (state->truncate_needed) {
                        fuse_do_truncate (state, state->size);
                } else {

when this happens the stack used for the other operation in SETATTR is not getting destroyed.

This was observed in a customer environment.

This does not affect the working of application making the calls though.

Comment 1 Anand Avati 2010-04-23 10:32:41 UTC
PATCH: http://patches.gluster.com/patch/3164 in master (mount/fuse: Destroy STACK when truncate and other op are part of same SETATTR)

Comment 2 Anand Avati 2010-04-23 10:33:13 UTC
PATCH: http://patches.gluster.com/patch/3165 in release-3.0 (mount/fuse: Destroy STACK when truncate and other op are part of same SETATTR)


Note You need to log in before you can comment on or make changes to this bug.