Bug 764678 (GLUSTER-2946) - refine invocation of external commands by gsyncd
Summary: refine invocation of external commands by gsyncd
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-2946
Product: GlusterFS
Classification: Community
Component: geo-replication
Version: mainline
Hardware: x86_64
OS: Linux
medium
low
Target Milestone: ---
Assignee: Csaba Henk
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 870502
TreeView+ depends on / blocked
 
Reported: 2011-05-25 12:49 UTC by Csaba Henk
Modified: 2012-10-26 16:53 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 870502 (view as bug list)
Environment:
Last Closed:
Regression: RTNR
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)

Description Csaba Henk 2011-05-25 12:49:16 UTC
gsyncd uses os.spawn* family of functions to invoke helper programs. These functions have poor feedback capabilites. Should move to a more comprehensive approach, which could feature:

- detect if command is not possible to invoke (execve failure)
- refine handling of result beyond the "success / failure" dichotomy
- reuse error messages of external programs as log messages

Most likely candidate is subprocess module, but it's not yet investigated if it's really suitable (beyond its availability in Python >= 2.4).

Comment 1 Anand Avati 2011-08-25 09:36:47 UTC
CHANGE: http://review.gluster.com/85 (Use subprocess module instead of os.spawn* / ad-hoc fork/exec.) merged in master by Vijay Bellur (vijay)

Comment 2 Anand Avati 2012-05-19 13:11:58 UTC
CHANGE: http://review.gluster.com/3258 (geo-rep / gsyncd: fixes regarding the command invocation framework) merged in master by Vijay Bellur (vijay)

Comment 3 Vijay Bellur 2012-07-09 04:14:40 UTC
CHANGE: http://review.gluster.com/3563 (geo-rep / gsyncd: sanitize error log of external commands) merged in release-3.3 by Vijay Bellur (vijay)

Comment 4 Vijay Bellur 2012-07-15 04:08:33 UTC
CHANGE: http://review.gluster.com/3561 (geo-rep / gsyncd: sanitize error log of external commands) merged in master by Anand Avati (avati)

Comment 5 Vijay Bellur 2012-07-15 04:09:48 UTC
CHANGE: http://review.gluster.com/3560 (geo-rep / gsyncd: fixes to communication with child processes) merged in master by Anand Avati (avati)

Comment 6 Vijay Bellur 2012-07-16 09:50:36 UTC
CHANGE: http://review.gluster.com/3562 (geo-rep / gsyncd: fixes to communication with child processes) merged in release-3.3 by Vijay Bellur (vbellur)


Note You need to log in before you can comment on or make changes to this bug.