Bug 764807 (GLUSTER-3075) - the 'fix.layout' command should happen through 'setxattr', not getxattr().
Summary: the 'fix.layout' command should happen through 'setxattr', not getxattr().
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-3075
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Amar Tumballi
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: GLUSTER-2258
TreeView+ depends on / blocked
 
Reported: 2011-06-23 04:31 UTC by Amar Tumballi
Modified: 2015-12-01 16:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: RTNR
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Amar Tumballi 2011-06-23 04:31:47 UTC

Comment 1 Jeff Darcy 2011-06-23 11:26:14 UTC
I don't disagree, but is there any *particular* reason setxattr would be preferred?

Comment 2 Anand Avati 2011-06-23 11:34:41 UTC
(In reply to comment #1)
> I don't disagree, but is there any *particular* reason setxattr would be
> preferred?

We are overhauling gluster volume rebalance. Part of that is to be able to have fine grained control of how a new layout should be. Eg. to span a directory across N nodes, or exclude host XYZ etc. setxattr's value will be used to specify such parameters for the 'fix.layout' key.

Avati

Comment 3 Anand Avati 2011-06-24 01:31:21 UTC
PATCH: http://patches.gluster.com/patch/7597 in master (distribute: handle 'fix.layout' key in setxattr() instead of getxattr())

Comment 4 Lakshmipathi G 2011-08-19 06:07:52 UTC
verified with 3.2.3qa3 - it didn't show any invalid argument error message.

with 3.2.2.
#setfattr -n trusted.glusterfs.fix.layout -v something /mnt/
#getfattr -d -m . /mnt
gave error message like 

"
[2011-08-19 14:31:59.36928] E [stat-prefetch.c:695:sp_remove_caches_from_all_fds_opened] (-->/opt/glusterfs/3.2.2//lib/glusterfs/3.2.2/xlator/mount/fuse.so(fuse_setxattr_resume+0x427) [0x7f28baa1aec2] (-->/opt/glusterfs/3.2.2//lib/glusterfs/3.2.2/xlator/debug/io-stats.so(io_stats_setxattr+0x2b0) [0x7f28b3df86a2] (-->/opt/glusterfs/3.2.2//lib/glusterfs/3.2.2/xlator/performance/stat-prefetch.so(sp_setxattr+0x151) [0x7f28b804ec22]))) 0-bug764807-stat-prefetch: invalid argument: inode
"


Note You need to log in before you can comment on or make changes to this bug.