Bug 765202 (GLUSTER-3470) - lgetxattr called with invalid keys on the bricks
Summary: lgetxattr called with invalid keys on the bricks
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-3470
Product: GlusterFS
Classification: Community
Component: replicate
Version: 3.2.2
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pranith Kumar K
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-08-23 08:18 UTC by tcp
Modified: 2014-06-24 11:02 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.5.1beta
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-24 11:02:45 UTC
Regression: ---
Mount Type: fuse
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description tcp 2011-08-23 08:18:54 UTC
[NOTE: Bug has been raised on 3.2.2 but I suspect it might also be present on 3.3 and mainline]

Test case to observe the problem:
-----------------------------------

0. On the brick, run, strace -o log -f -p <glusterfsd pid>
1. Create a file on a mount of a distribute-replicate volume (make sure that this file hashes onto the server you are tracing)
2 Terminate the strace process on the brick

Relevant logs from my exercise:
-------------------------------------

# grep EOPNOTSUPP log.noacl.1file

21893 15:30:06.407721 lgetxattr("/data/pavan/datastore/", "gfid-req", 0x0, 0) = -1 EOPNOTSUPP (Operation not supported) <0.000009>
21893 15:30:06.407772 lgetxattr("/data/pavan/datastore/", "glusterfs.content", 0x0, 0) = -1 EOPNOTSUPP (Operation not supported) <0.000009>
21893 15:30:06.408172 lgetxattr("/data/pavan/datastore/", "glusterfs.inodelk-count", 0x0, 0) = -1 EOPNOTSUPP (Operation not supported) <0.000009>
21893 15:30:06.408224 lgetxattr("/data/pavan/datastore/", "glusterfs.entrylk-count", 0x0, 0) = -1 EOPNOTSUPP (Operation not supported) <0.000009>

The lgetxattr keys are invalid since they do not have any of the supported "trusted", "system", "user" prefixes.

The following are the violating keys:

-- "gfid-req"
-- "glusterfs.content"
-- "glusterfs.inodelk-count"
-- "glusterfs.entrylk-count"

Pavan

Comment 1 Anand Avati 2011-09-20 05:50:07 UTC
CHANGE: http://review.gluster.com/326 (Change-Id: Icb67cd739410071a07a9511e28c075fe8e9b9eaf) merged in release-3.2 by Vijay Bellur (vijay)

Comment 2 Anand Avati 2011-09-20 05:50:23 UTC
CHANGE: http://review.gluster.com/327 (Change-Id: I98306f7246798422b3f0c04de29962bd5b62d03f) merged in release-3.1 by Vijay Bellur (vijay)

Comment 3 Anand Avati 2011-09-20 14:32:36 UTC
CHANGE: http://review.gluster.com/325 (Change-Id: If948ff1b355ea4fd92036bcc43e7b32325aeb3e4) merged in master by Vijay Bellur (vijay)

Comment 4 Kaleb KEITHLEY 2014-02-14 13:18:00 UTC
some additional non-xattr keys have crept in:

10480 lgetxattr("/mnt/brick1/brick/smf5", "gfidless-lookup", 0x0, 0) = -1 EOPNOTSUPP (Operation not supported)
10480 lgetxattr("/mnt/brick1/brick/smf5", "glusterfs.parent-entrylk", 0x0, 0) = -1 EOPNOTSUPP (Operation not supported)

Comment 5 Anand Avati 2014-02-14 13:23:19 UTC
REVIEW: http://review.gluster.org/7003 (storage/posix:  lgetxattr called with invalid keys on the bricks) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 6 Anand Avati 2014-02-14 13:28:10 UTC
REVIEW: http://review.gluster.org/7004 (storage/posix:  lgetxattr called with invalid keys on the bricks) posted (#1) for review on release-3.5 by Kaleb KEITHLEY (kkeithle)

Comment 7 Anand Avati 2014-02-14 13:30:53 UTC
REVIEW: http://review.gluster.org/7005 (storage/posix:  lgetxattr called with invalid keys on the bricks) posted (#1) for review on release-3.4 by Kaleb KEITHLEY (kkeithle)

Comment 8 Anand Avati 2014-02-14 13:31:58 UTC
REVIEW: http://review.gluster.org/7003 (storage/posix:  lgetxattr called with invalid keys on the bricks) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 9 Anand Avati 2014-02-17 05:54:25 UTC
COMMIT: http://review.gluster.org/7003 committed in master by Anand Avati (avati) 
------
commit 7b3207168ef5496702ab10d48be4e4d7cf1f413b
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Fri Feb 14 08:20:44 2014 -0500

    storage/posix:  lgetxattr called with invalid keys on the bricks
    
    More invalid keys have crept in since this was fixed. We need a better
    strategy for avoiding this than the current noticed-in-an-strace...
    
    Cleaning tabs while I'm at it.
    
    Change-Id: I2ea97f6d1ab2a9fd569b5b5e01a4de891401fb81
    BUG: 765202
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/7003
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 10 Anand Avati 2014-03-24 15:25:37 UTC
COMMIT: http://review.gluster.org/7005 committed in release-3.4 by Kaleb KEITHLEY (kkeithle) 
------
commit 33cc417e6431a2739f463d83e62befff4ccab8f5
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Fri Feb 14 08:29:28 2014 -0500

    storage/posix:  lgetxattr called with invalid keys on the bricks
    
    More invalid keys have crept in since this was fixed. We need a better
    strategy for avoiding this than the current noticed-in-an-strace...
    
    Cleaned tabs while I'm at it.
    
    Change-Id: I00bd10471c4e4caf32b8a5b38660268324aa7a10
    BUG: 765202
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/7005
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 11 Anand Avati 2014-05-05 20:35:24 UTC
COMMIT: http://review.gluster.org/7004 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit b50edddcddc6ef943a36e0535e3bc85d714867ef
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Fri Feb 14 08:25:31 2014 -0500

    storage/posix:  lgetxattr called with invalid keys on the bricks
    
    More invalid keys have crept in since this was fixed. We need a better
    strategy for avoiding this than the current noticed-in-an-strace..
    
    Cleaned tabs while I'm at it.
    
    Change-Id: I0d5d3dd925cc626d06768b022ea0a572a9ea7e06
    BUG: 765202
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/7004
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 12 Niels de Vos 2014-05-25 09:06:43 UTC
The first (and last?) Beta for GlusterFS 3.5.1 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.1beta release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-May/040377.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 13 Niels de Vos 2014-06-24 11:02:45 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.1, please reopen this bug report.

glusterfs-3.5.1 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-June/040723.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.