Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 766939 - security_token.rb should be regenerated on each install
Summary: security_token.rb should be regenerated on each install
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Packaging
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: Unspecified
Assignee: Lukas Zapletal
QA Contact: Katello QA List
URL:
Whiteboard:
Depends On:
Blocks: katello-blockers
TreeView+ depends on / blocked
 
Reported: 2011-12-12 20:14 UTC by Mike McCune
Modified: 2019-09-26 13:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-22 18:13:06 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 848905 1 None None None 2021-01-20 06:05:38 UTC

Internal Links: 848905

Description Mike McCune 2011-12-12 20:14:35 UTC 
copied from AC:

https://www.aeolusproject.org/redmine/issues/2660

This is used to sign session cookies. If all Conductor installations have the same key, it allows an attacker to modify or craft session cookies and then sign them so that the server will trust them.

FWIW, I sent a patch to solve this, but it's sparked some further discussion on the right way to tackle this: https://fedorahosted.org/pipermail/aeolus-devel/2011-October/006010.html


note there is a patch mentioned in above thread:

https://fedorahosted.org/pipermail/aeolus-devel/2011-October/006011.html
Comment 1 Lukas Zapletal 2011-12-13 12:12:27 UTC 
I am not big fan of running rake task in the RPM post section. First of all its slow, second it can fail if any of our ruby dependencies does not match version.

So I am adding this:

sed -i "s/^Src::Application.config.secret_token = '.*'/Src::Application.config.secret_token = '$(</dev/urandom tr -dc A-Za-z0-9 | head -c128)'/" config/initializers/secret_token.rb

It also generates BASE64-like string instead of simple hexa string. This is more secure.
Comment 2 Lukas Zapletal 2011-12-13 12:50:44 UTC 
1) I can confirm the string does not have to be hexa. It works with any 
(base64 etc) encoded string.

2) Rake use Bundler and we were facing many issues with incorrect 
dependencies (discussed on the ruby sig list). I tend not to use 
Bundler-based things in the RPM postun sections, because even when deps
would be incorrect, I would like to have the RPM to be properly 
installed. Therefore we generate the same using tr and sed tools.

http://git.fedorahosted.org/git/?p=katello.git;a=commitdiff;h=738bf1479390ba3d2df88ba24d43b9fbd118b160

It's also much faster.

3) Since the secret_token file is distributed, MD5 RPM validation fails.
I don't think this is an issue.

$ rpm -qV katello-common
5..T.....    /usr/share/katello/config/initializers/secret_token.rb


738bf14 766939 - security_token.rb should be regenerated on each install
Comment 4 Corey Welton 2012-02-08 14:10:42 UTC 
QA Verified that this is getting regenerated.
Note You need to log in before you can comment on or make changes to this bug.