Hide Forgot
Description of problem: Running anaconda with "console=ttyS0,115200n81" and "serial" generates config for /etc/default/grub, which is correct for linux command line, but faulty for grub serial command. For example: GRUB_TIMEOUT=5 GRUB_DISTRIBUTOR="Fedora" GRUB_DEFAULT=saved GRUB_TERMINAL="serial console" GRUB_SERIAL_COMMAND="serial --unit=0 --speed=9600" GRUB_CMDLINE_LINUX="rd.lvm.lv=vg_amddinar03/lv_swap rd.md=0 rd.lvm.lv=vg_amddinar03/lv_root rd.luks=0 console=ttyS0,115200n81 LANG=en_US.UTF-8 SYSFONT=latarcyrheb-sun16 KEYTABLE=us rd.dm=0" This is snippet from sources, where I'm guessing it fails on "115200n81".isgidit() -------------------------------------------------------------------- def serial_command(self): command = "" if self.console and self.console.startswith("ttyS"): unit = self.console[-1] speed = "9600" for opt in self.console_options.split(","): if opt.isdigit(): speed = opt break command = "serial --unit=%s --speed=%s" % (unit, speed) return command -------------------------------------------------------------------- Version-Release number of selected component (if applicable): anaconda-16.25-1.fc16 How reproducible: 100% Steps to Reproduce: 1. run anaconda with "console=ttyS0,115200n81 serial" 2. check if grub menu is accessible over serial console 3. Actual results: can't access grub menu over serial console Expected results: correct config in /etc/default/grub, grub accessible over serial console Additional info:
Any chance of some movement on this?
I'll work on it as soon as I have time.
Patches are always welcome, of course. That'll usually help get things done faster. Tested patches are even better - consult http://fedoraproject.org/wiki/Anaconda/Updates for a simple way to test patches.
Created attachment 551536 [details] proposed patch v1 Proposed patch to fix serial console options parsing for grub GRUB_SERIAL_COMMAND.
Created attachment 551668 [details] a slightly different proposed patch This is a different proposed patch that tries to avoid adding unnecessary options to the 'serial' command. Could you test it and see if it works for you?
(In reply to comment #6) > This is a different proposed patch that tries to avoid adding unnecessary > options to the 'serial' command. > > Could you test it and see if it works for you? Looks good. I ran it on few random hosts, grub serial command had expected value, and I could interact with grub menu (via conserver). console=ttyS0,115200n81 GRUB_SERIAL_COMMAND="serial --speed=115200" console=ttyS1,115200n81 GRUB_SERIAL_COMMAND="serial --unit=1 --speed=115200" console=ttyS1,57600n81 GRUB_SERIAL_COMMAND="serial --unit=1 --speed=57600"
Fix has been committed to anaconda: db77ca3 fix serial console option parsing (#767745) it's currently in f17-branch and master.
This message is a reminder that Fedora 16 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 16. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '16'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 16's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 16 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged to click on "Clone This Bug" and open it against that version of Fedora. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping
Fedora 16 changed to end-of-life (EOL) status on 2013-02-12. Fedora 16 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed.