Bug 768286 - Review Request: libskk - Library to deal with Japanese kana-to-kanji conversion method
Summary: Review Request: libskk - Library to deal with Japanese kana-to-kanji conversi...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-16 08:51 UTC by Daiki Ueno
Modified: 2012-01-07 23:10 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-20 04:59:39 UTC
Type: ---
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Daiki Ueno 2011-12-16 08:51:11 UTC
Spec URL: http://ueno.fedorapeople.org/libskk/libskk.spec
SRPM URL: http://ueno.fedorapeople.org/libskk/libskk-0.0.2-1.fc16.src.rpm
Description:
The libskk project aims to provide GObject-based interface of Japanese
input methods.  Currently it supports SKK (Simple Kana Kanji) with
various typing rules including romaji-to-kana, AZIK, ACT, TUT-Code,
T-Code, and NICOLA.

This package is necessary to build the next release of ibus-skk.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3588356

Comment 1 Parag AN(पराग) 2011-12-19 10:47:01 UTC
Review:-

+ koji scratch build for f17-> http://koji.fedoraproject.org/koji/taskinfo?taskID=3588356

+ rpmlint on rpms gave 
libskk.src: W: spelling-error Summary(en_US) kana -> Sana, Lana, Dana
libskk.src: W: spelling-error Summary(en_US) kanji -> Kantian
libskk.src: W: spelling-error %description -l en_US romaji -> Romania
libskk.src: W: spelling-error %description -l en_US kana -> Sana, Lana, Dana
libskk.x86_64: W: spelling-error Summary(en_US) kana -> Sana, Lana, Dana
libskk.x86_64: W: spelling-error Summary(en_US) kanji -> Kantian
libskk.x86_64: W: spelling-error %description -l en_US kana -> Sana, Lana, Dana
libskk.x86_64: W: spelling-error %description -l en_US kanji -> Kantian
libskk.x86_64: W: spelling-error %description -l en_US romaji -> Romania
libskk.x86_64: E: description-line-too-long C kana-kanji conversion algorithms, based on GObject.  Currently it supports SKK (Simple
libskk.x86_64: E: description-line-too-long C Kana Kanji) input method with various typing rules including romaji-to-kana, AZIK, ACT, TUT-Code, T-Code, and NICOLA.
libskk.x86_64: W: no-manual-page-for-binary skk
libskk-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 2 errors, 11 warnings.
==> Fix the description error

+ Source verified with upstream as (sha1sum)
cdf7faadd96c7c22ecaa529f39f102dc87e08af6  libskk-0.0.2.tar.gz
cdf7faadd96c7c22ecaa529f39f102dc87e08af6  ../SOURCES/libskk-0.0.2.tar.gz

+ rest looks ok.


suggestions
1) COPYING should be added to %doc
2) fix the rpmlint error.

APPROVED.

Comment 2 Daiki Ueno 2011-12-20 00:58:56 UTC
Thanks for the review, Parag.  I'll reflect your suggestions at the first import.

New Package SCM Request
=======================
Package Name: libskk
Short Description: Library to deal with Japanese kana-to-kanji conversion method
Owners: ueno
Branches: f16 f15
InitialCC: i18n-team

Comment 3 Gwyn Ciesla 2011-12-20 02:56:28 UTC
Git done (by process-git-requests).

Comment 4 Daiki Ueno 2011-12-20 04:59:39 UTC
Thanks.  Imported and built in koji.

Comment 5 Fedora Update System 2011-12-26 03:07:40 UTC
libskk-0.0.5-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/libskk-0.0.5-1.fc16

Comment 6 Fedora Update System 2011-12-26 09:27:14 UTC
libskk-0.0.5-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/libskk-0.0.5-1.fc15

Comment 7 Fedora Update System 2012-01-07 23:03:02 UTC
libskk-0.0.5-1.fc16 has been pushed to the Fedora 16 stable repository.

Comment 8 Fedora Update System 2012-01-07 23:10:05 UTC
libskk-0.0.5-1.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.