Spec URL: http://fedorapeople.org/~dgoodwin/subscription-manager/subscription-manager.spec SRPM URL: http://fedorapeople.org/~dgoodwin/subscription-manager/subscription-manager-0.99.2-1.fc16.src.rpm Description: Subscription manager offers tools for registration, consumption of subscriptions, and ultimately access to content in protected yum repositories. It is a core component for systems to register and interact with the Katello systems management platform. (http://katello.org/)
Taking the review. First look: rpmlint subscription-manager-0.99.2-1.fc16.src.rpm subscription-manager.src:11: W: macro-in-comment %{version} subscription-manager.src:11: W: macro-in-comment %{release} subscription-manager.src:162: E: hardcoded-library-path in %{_prefix}/lib/yum-plugins/subscription-manager.py* subscription-manager.src:163: E: hardcoded-library-path in %{_prefix}/lib/yum-plugins/product-id.py* subscription-manager.src:164: E: hardcoded-library-path in %{_prefix}/lib/yum-plugins/katello.py* subscription-manager.src: W: invalid-url Source0: subscription-manager-0.99.2.tar.gz All errors and warning above are properly commented in the spec and are not problems. Formal review will follow later on.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3614692 FORMAL REVIEW MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] The LICENSE file is missing, distribution for all subpackages is recommended. MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. I would suggest to add one line instructing user to install tito, not all of use know what tito is. Not a blocker. Excelent work for such a complicated package, only minor points. *** APPROVED ***
Devan, please fix the minor issue (LICENSE file distribution) before you commit to the distgit. *** PACKAGE IS APPROVED ***
For completeness I am attaching rpmlint for binaries: subscription-manager-firstboot.i686: W: no-documentation subscription-manager-gnome.i686: W: non-conffile-in-etc /etc/pam.d/subscription-manager-gui subscription-manager-gnome.i686: W: non-conffile-in-etc /etc/security/console.apps/subscription-manager-gui subscription-manager.src:11: W: macro-in-comment %{version} subscription-manager.src:11: W: macro-in-comment %{release} subscription-manager.src:162: E: hardcoded-library-path in %{_prefix}/lib/yum-plugins/subscription-manager.py* subscription-manager.src:163: E: hardcoded-library-path in %{_prefix}/lib/yum-plugins/product-id.py* subscription-manager.src:164: E: hardcoded-library-path in %{_prefix}/lib/yum-plugins/katello.py* subscription-manager.src: W: invalid-url Source0: subscription-manager-0.99.2.tar.gz subscription-manager.i686: W: only-non-binary-in-usr-lib subscription-manager.i686: W: non-conffile-in-etc /etc/bash_completion.d/subscription-manager subscription-manager.i686: W: non-conffile-in-etc /etc/security/console.apps/subscription-manager subscription-manager.i686: W: no-dependency-on usermode subscription-manager.i686: W: manual-page-warning /usr/share/man/man8/subscription-manager.8.gz 672: warning: macro `pp' not defined subscription-manager.i686: W: non-conffile-in-etc /etc/pam.d/subscription-manager subscription-manager.i686: W: service-default-enabled /etc/rc.d/init.d/rhsmcertd subscription-manager.i686: W: incoherent-init-script-name rhsmcertd ('subscription-manager', 'subscription-managerd') 5 packages and 0 specfiles checked; 3 errors, 14 warnings. No blockers.
New Package SCM Request ======================= Package Name: subscription-manager Short Description: Tools and libraries for subscription and repository management. Owners: dgoodwin jbowes Branches: f15 f16 InitialCC:
Filed this on my work account, suspect that is why I can't set fedora-cvs flag.
Git done (by process-git-requests).