Version-Release number of selected component (if applicable):
nss-3.12.10-17.el6_2


How reproducible:
100%


Steps to Reproduce:
1. run the attached test-case

  
Actual results:
43,008 bytes in 256 blocks are definitely lost in loss record 75 of 75
   at 0x4A04A28: calloc (vg_replace_malloc.c:467)
   by 0x331A4236CC: PR_NewLock (ptsynch.c:174)
   by 0x4C36D24: nssCKFWMutex_Create (mutex.c:137)
   by 0x4C36989: nssCKFWInstance_Create (instance.c:245)
   by 0x4C40FAF: NSSCKFWC_Initialize (wrap.c:205)
   by 0x4E98F06: secmod_ModuleInit (pk11load.c:252)
   by 0x4E99886: secmod_LoadPKCS11Module (pk11load.c:492)
   by 0x4EAE354: SECMOD_LoadModule (pk11pars.c:1121)
   by 0x4EAE5C7: SECMOD_LoadUserModule (pk11pars.c:1209)
   by 0x40080F: main (ckfw-leak.c:19)

LEAK SUMMARY:
   definitely lost: 43,008 bytes in 256 blocks
   indirectly lost: 0 bytes in 0 blocks
     possibly lost: 0 bytes in 0 blocks
   still reachable: 11,137 bytes in 88 blocks
        suppressed: 0 bytes in 0 blocks


Expected results (I get this after downgrade to nss-3.12.10-11.el6):
LEAK SUMMARY:
   definitely lost: 0 bytes in 0 blocks
   indirectly lost: 0 bytes in 0 blocks
     possibly lost: 0 bytes in 0 blocks
   still reachable: 11,137 bytes in 88 blocks
        suppressed: 0 bytes in 0 blocks


Additional info:
The CKFW code has been broken since RHEL-6.0, but it did not take any effect until nss-3.12.10-13.el6, where the following patch was applied:

--- ./mozilla/security/nss/lib/ckfw/pem/pinst.c.735047
+++ ./mozilla/security/nss/lib/ckfw/pem/pinst.c
@@ -377,7 +377,6 @@ AddCertificate(char *certfile, char *key
                CK_SLOT_ID slotID)
 {
     pemInternalObject *o;
-    SECItem certDER;
     CK_RV error = 0;
     int objid, i;
     int nobjs = 0;
@@ -385,7 +384,6 @@ AddCertificate(char *certfile, char *key
     char *ivstring = NULL;
     int cipher;

-    certDER.data = NULL;
     nobjs = ReadDERFromFile(&objs, certfile, PR_TRUE, &cipher, &ivstring, PR_TRUE /* certs only */);
     if (nobjs <= 0) {
         nss_ZFreeIf(objs);
@@ -469,32 +467,36 @@ pem_Initialize
 )
 {
     CK_RV rv;
-    /* parse the initialization string and initialize CRLInstances */
+    /* parse the initialization string */
     char **certstrings = NULL;
+    char *modparms = NULL;
     PRInt32 numcerts = 0;
     PRBool status, error = PR_FALSE;
     int i;
+    CK_C_INITIALIZE_ARGS_PTR modArgs = NULL;
+
+    if (!fwInstance) return CKR_ARGUMENTS_BAD;
+
+    modArgs = NSSCKFWInstance_GetInitArgs(fwInstance);
+    if (modArgs &&
+       ((modArgs->flags & CKF_OS_LOCKING_OK) || (modArgs->CreateMutex != 0))) {
+        return CKR_CANT_LOCK;
+    }