Spec URL: http://averi.fedorapeople.org/RPMs/trac-navadd-plugin/trac-navadd-plugin.spec
SRPM URL: http://averi.fedorapeople.org/RPMs/trac-navadd-plugin/trac-navadd-plugin-0.9-1.fc16.src.rpm
Description: A trac plugin that should allow you to add custom items ("buttons")
to both the main and the meta navigation bar.
I'll review this. Look for a full review in a bit.
Before the full review, one issue:
Could you change the versioning and Source ?
Trac plugins sadly don't have anything like stable releases, everything is checked out from svn.
I'd suggest here:
and then in the spec something like:
# Produce via 'svn export -r11020 http://trac-hacks.org/svn/navaddplugin/0.9 navaddplugin'
# tar -czvf navaddplugin-0.9.svn11020.tar.gz navaddplugin
sure, I'll update everything in a minute.
Done. Everything has been pushed to:
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
1. Not a blocker, but you might ask upstream to include a copy of the BSD
license with the package.
2. rpmlint says:
trac-navadd-plugin.noarch: W: no-documentation
trac-navadd-plugin.src: W: invalid-url Source0: trac-navadd-plugin-0.9.svn11020.tar.gz
Both can be ignored.
I don't see any blockers here, so this package is APPROVED.
I'm happy to co-maintain if you like.
New Package SCM Request
Package Name: trac-navadd-plugin
Short Description: Trac's plugin that allows the addition of custom items
Owners: averi kevin
Branches: f16 el6
InitialCC: averi kevin
Git done (by process-git-requests).
Built fine, closing ticket.
trac-navadd-plugin-0.9.0.1-20111223svn11020.el6 has been submitted as an update for Fedora EPEL 6.
trac-navadd-plugin-0.9.0.1-20111223svn11020.el6 has been pushed to the Fedora EPEL 6 stable repository.