Spec URL: http://averi.fedorapeople.org/RPMs/trac-workflowadmin-plugin/trac-workflowadmin-plugin.spec
SRPM URL: http://averi.fedorapeople.org/RPMs/trac-workflowadmin-plugin/trac-workflowadmin-plugin-0.12-1.fc16.src.rpm
Description: The plugin provides the editor for workflow and the diagram of workflow using the Graphviz programs.
@Kevin, I've built you up a package already for testing purposes, it's available at:
Thanks. I'll look at reviewing this soon.
Can you look at the other review and adjust the source/version for svn ?
Updated files as per #769922 comments can be found at:
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
1. Not a blocker, but you might ask upstream to include a copy of the BSD
license with the package.
2. rpmlint says:
trac-workflowadmin-plugin.noarch: W: spelling-error Summary(en_US) workflow -> work flow, work-flow, workforce
trac-workflowadmin-plugin.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
trac-workflowadmin-plugin.noarch: W: no-documentation
trac-workflowadmin-plugin.src: W: spelling-error Summary(en_US) workflow -> work flow, work-flow, workforce
trac-workflowadmin-plugin.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
trac-workflowadmin-plugin.src: W: invalid-url Source0: trac-workflowadmin-plugin-0.12.svn11020.tar.gz
all can be ignored.
I don't see any blockers here, so this package is APPROVED.
Happy to co-maintain.
New Package SCM Request
Package Name: trac-workflowadmin-plugin
Short Description: Web interface for workflow administration for Trac
Owners: averi kevin
Branches: f16 el6
InitialCC: averi kevin
Git done (by process-git-requests).
Built fine, closing ticket.
trac-workflowadmin-plugin-0.12-20111223svn11062.el6 has been submitted as an update for Fedora EPEL 6.
trac-workflowadmin-plugin-0.12-20111223svn11062.el6 has been pushed to the Fedora EPEL 6 stable repository.