Hide Forgot
Spec URL: http://averi.fedorapeople.org/RPMs/trac-tocmacro-plugin/trac-tocmacro-plugin.spec SRPM URL: http://averi.fedorapeople.org/RPMs/trac-tocmacro-plugin/trac-tocmacro-plugin-0.11.0.0.3-20111225svn11062.fc16.src.rpm Description: The TocMacro's Trac plugin generates a table of contents for the current page or a set of pages.
I'll go ahead and review this. Look for a full review later today.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) see below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Might ask upstream to include a copy of the license. Not a blocker. 2. rpmlint says: trac-tocmacro-plugin.noarch: W: no-documentation trac-tocmacro-plugin.src: W: invalid-url Source0: trac-tocmacro-plugin-0.11.svn11062.tar.gz Can both be ignored. I don't see any blockers here, so this package is APPROVED. I'm happy to co-maintain.
New Package SCM Request ======================= Package Name: trac-tocmacro-plugin Short Description: Trac plugin table of content macro Owners: averi kevin Branches: f16 el6 InitialCC: averi kevin
Git done (by process-git-requests).
Built fine.
trac-workflowadmin-plugin-0.12-20111223svn11062.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-workflowadmin-plugin-0.12-20111223svn11062.el6
trac-tocmacro-plugin-0.11.0.0.3-20111225svn11062.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-tocmacro-plugin-0.11.0.0.3-20111225svn11062.el6
trac-tocmacro-plugin-0.11.0.0.3-20111225svn11062.el6 has been pushed to the Fedora EPEL 6 stable repository.