Bug 770618 - Pool with similar names can be created across pool families
Summary: Pool with similar names can be created across pool families
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: CloudForms Cloud Engine
Classification: Retired
Component: aeolus-conductor
Version: 1.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
Assignee: Ken Keiter
QA Contact: wes hayutin
URL:
Whiteboard:
Depends On:
Blocks: ce-sprint
TreeView+ depends on / blocked
 
Reported: 2011-12-28 04:20 UTC by Aziza Karol
Modified: 2012-02-22 16:17 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-22 16:17:25 UTC
athomas: needinfo-


Attachments (Terms of Use)
pool names (229.15 KB, image/png)
2011-12-28 04:21 UTC, Aziza Karol
no flags Details

Description Aziza Karol 2011-12-28 04:20:15 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.Create a pool family with name called "family-aziza".
2.create a pool called "default" in the above family. 

pool with name "default" gets created in family "family-aziza".although pool with name Default already exists in Default family.
see attached screenshot.


i see that if the first letter of the pool name is either capital or small ,pool with same name gets created across families.

  
Expected results:
validation required.

Additional info:
[root@dell-pe2950-1 ~]# rpm -qa | grep  aeolus
aeolus-conductor-daemons-0.8.0-0.20111222233342gitd98cb57.el6.noarch
rubygem-aeolus-image-0.3.0-0.20111222173411gitc13b654.el6.noarch
rubygem-aeolus-cli-0.3.0-0.20111222173356git3cd6277.el6.noarch
aeolus-all-0.8.0-0.20111222233342gitd98cb57.el6.noarch
aeolus-configure-2.5.0-0.20111222173430git17b704a.el6.noarch
aeolus-conductor-0.8.0-0.20111222233342gitd98cb57.el6.noarch
aeolus-conductor-doc-0.8.0-0.20111222233342gitd98cb57.el6.noarch
[root@dell-pe2950-1 ~]#

Comment 1 Aziza Karol 2011-12-28 04:21:40 UTC
Created attachment 549777 [details]
pool names

Comment 2 wes hayutin 2012-01-10 17:10:22 UTC
adding to ce-sprint-next

Comment 3 wes hayutin 2012-01-10 17:12:56 UTC
adding to ce-sprint-next

Comment 4 wes hayutin 2012-01-12 16:34:35 UTC
adding to ce-sprint

Comment 5 wes hayutin 2012-01-12 16:40:57 UTC
removing ce-sprint-next tracker

Comment 6 Angus Thomas 2012-01-13 13:16:32 UTC
I'm not seeing the case for taking the ability to create identical or near-identical names for pools across pool families away from Administrators.

Unless the actual problem can be articulated more precisely, this should be closed.

Comment 7 wes hayutin 2012-01-16 13:59:16 UTC
Well.. the only case I can make.. is that from the monitor page.. it would look pretty stupid to have three pools listed w/ the same name..

Perhaps you want to have some kind of indication of the pool family from the monitor page.. even if its just a hover over txt or something

moving back to Angus

Comment 8 Angus Thomas 2012-01-26 14:42:47 UTC
Ken, 

Can you propose a means to address this, without too much disruption to the current page?


Angus

Comment 9 Ken Keiter 2012-02-03 12:57:45 UTC
This isn't an issue with the layout/design -- it's more of an issue with user-generated taxonomy rules. Do we wish to ensure that pool names are unique even across environments, or should a user be allowed to create two "default" pools in separate environments?

Comment 10 Hugh Brock 2012-02-08 16:19:59 UTC
We don't care about making pool names unique, no -- we just want the user to be able to tell them apart. Wes' suggestion of a rollover hint seems fine to me.

Comment 11 Ken Keiter 2012-02-09 16:26:57 UTC
So, the problem with a rollover hint on the monitor page is that it would interfere with the click area, and potentially be misleading to the user. For example, when you hover over the "default" pool and see the environment name, some users' expectations might be that a click action would take you to an environment page.

My recommendation would be to place each block of pools under a header which shows the environment. Is that okay with everyone? It won't be perfect, but it'll work.

Comment 12 Ken Keiter 2012-02-16 16:18:45 UTC
Talked to a few of the guys -- turns out, looking at the models, that we were supposed to be validating that duplicate pool names could not be created; however, Rails changed some syntax in validates_uniqueness_of such that :case_sensitive must now be manually set to => true.

Submitting a patch for both product and upstream.

Comment 13 Ken Keiter 2012-02-22 16:17:25 UTC
Okay, after much further deliberation between matty_dubs, sseago, and myself we've decided that this should be closed as notabug. I put it up for comment on the list, and received no feedback -- so here we go:

This is not a bug because the user should be required to have an understanding and mental model of the names of their pools, and any "fix" (read: handholding) that we wished to apply for this would have a much larger impact across the application, rather than just two or three areas.


Note You need to log in before you can comment on or make changes to this bug.