Bug 770739 - RPS/RFS: Invalid rxhash handling
Summary: RPS/RFS: Invalid rxhash handling
Keywords:
Status: CLOSED DUPLICATE of bug 757040
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Jiri Benc
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-28 20:04 UTC by Marcelo Ricardo Leitner
Modified: 2018-11-29 21:38 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-24 18:04:24 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Comment 2 Marcelo Ricardo Leitner 2011-12-29 17:05:01 UTC 
Test kernel available at http://people.redhat.com/~mleitner/bz770739/
Comment 3 Jiri Benc 2012-01-04 13:06:52 UTC 
The reasoning looks valid to me. Neil, commit cd045e31 contains

-u16 tcpu = map->cpus[((u32) (skb->rxhash * map->len)) >> 16];
+tcpu = map->cpus[((u64) skb->rxhash * map->len) >> 32];

Could you confirm this is just an overlook? Thanks!
Comment 4 Neil Horman 2012-01-04 15:02:09 UTC 
Jiri, yes, thats correct, Due to ABI contraints we have to shift by 16 instead of 32 and cast to a u32
Comment 8 Jiri Benc 2012-02-24 18:04:24 UTC 

*** This bug has been marked as a duplicate of bug 757040 ***
Note You need to log in before you can comment on or make changes to this bug.