Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-gstreamer/rubygem-gstreamer.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-gstreamer/rubygem-gstreamer-1.0.3-1.fc.src.rpm Description: Ruby/GStreamer is a Ruby binding of GStreamer. Koji scratch build: f17 http://koji.fedoraproject.org/koji/taskinfo?taskID=3608912 f16 http://koji.fedoraproject.org/koji/taskinfo?taskID=3608915
http://mtasaka.fedorapeople.org/Review_request/rubygem-gstreamer/rubygem-gstreamer-1.0.3-3.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-gstreamer/rubygem-gstreamer.spec * Sat Dec 31 2011 Mamoru Tasaka <mtasaka> - 1.0.3-3 - Rescue test failure * Thu Dec 29 2011 Mamoru Tasaka <mtasaka> - 1.0.3-2 - Add BR: gstreamer-plugins-good for smpte_caps in test/test_caps.rb - Add BR: rubygem(test-unit)
I'll post my review today.
- = N/A x = Check ! = Problem ? = Not evaluated [x] : MUST - Package is named according to the Package Naming Guidelines. [x] : MUST - Spec file name must match the spec package %{name}, in the format %{name}.spec. [x] : MUST - Not have unused macro definitions (i.e. %global ) [x] : MUST - Fully versioned dependency in subpackages, if present. [x] : MUST - Package does not contain any libtool archives (.la) [-] : MUST - Package use %makeinstall only when make install DESTDIR=... doesn't work. [x] : MUST - Package successfully compiles and builds into binary rpms on at least one supported architecture. [x] : MUST - Sources used to build the package matches the upstream source, as provided in the spec URL. [-] : MUST - %config files are marked noreplace or the reason is justified. [-] : MUST - Package contains a properly installed %{name}.desktop using desktop-file-install file if it is a GUI application. [-] : MUST - Header files in -devel subpackage, if present. [-] : MUST - Development .so files in -devel subpackage, if present. [-] : MUST - ldconfig called in %post and %postun if required. [-] : MUST - The spec file handles locales properly. [-] : MUST - Static libraries in -static subpackage, if present. [x] : MUST - Rpmlint output is silent. [-] : MUST - No %config files under /usr. [x] : MUST - Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] : MUST - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x] : MUST - Package contains no bundled libraries. [x] : MUST - Changelog in prescribed format. [x] : MUST - Sources contain only permissible code or content. [x] : MUST - Macros in Summary, %description expandable at SRPM build time. [-] : MUST - Package requires other packages for directories it uses. [x] : MUST - Package uses nothing in %doc for runtime. [x] : MUST - Package is not known to require ExcludeArch. [x] : MUST - Permissions on files are set properly. [x] : MUST - Package does not contain duplicates in %files. [x] : MUST - Large documentation files are in a -doc subpackage, if required. [-] : MUST - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] : MUST - License field in the package spec file matches the actual license. [-] : MUST - License file installed when any subpackage combination is installed. [x] : MUST - Package consistently uses macros. instead of hard-coded directory names. [x] : MUST - Package meets the Packaging Guidelines. [x] : MUST - Package does not generates any conflict. [-] : MUST - Package does not contains kernel modules. [-] : MUST - Package contains no static executables. [x] : MUST - Package must own all directories that it creates. [x] : MUST - Package does not own files or directories owned by other packages. [x] : MUST - Package installs properly. [x] : MUST - Rpath absent or only used for internal libs. [x] : MUST - Package is not relocatable. [x] : MUST - Requires correct, justified where necessary. [x] : MUST - Spec file is legible and written in American English. [x] : MUST - File names are valid UTF-8. [x] : MUST - Useful -debuginfo package or justification otherwise. [x] : SHOULD - Reviewer should test that the package builds in mock. [x] : SHOULD - Dist tag is present. [x] : SHOULD - SourceX / PatchY prefixed with %{name}. [x] : SHOULD - SourceX is a working URL. [x] : SHOULD - Spec use %global instead of %define. [x] : SHOULD - The placement of pkgconfig(.pc) files are correct. [!] : SHOULD - If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x] : SHOULD - Latest version is packaged. [x] : SHOULD - Package does not include license text files separate from upstream. [x] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise justified. [x] : SHOULD - Scriptlets must be sane, if used. [x] : SHOULD - Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] : SHOULD - Package should compile and build into binary rpms on all supported architectures. [x] : SHOULD - %check is present and all tests pass. Issues: [!] : SHOULD ask upstream to include a copy of the actual license (not a blocker) APPROVED
Thank you for reviewing! New Package SCM Request ======================= Package Name: rubygem-gstreamer Short Description: Ruby binding of GStreamer Owners: mtasaka Branches: f16 f15
Git done (by process-git-requests).
Rebuild successfully, pushed into rawhide and submitted for F-16/15 testing. Thank you for the review and git procedure, closing.