Bug 770942 – memory leaks on libvirt_virDomainBlockStatsFlags

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 770942 - memory leaks on libvirt_virDomainBlockStatsFlags

Summary:	memory leaks on libvirt_virDomainBlockStatsFlags

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	libvirt (Show other bugs)
Sub Component:
Version:	6.3
Hardware:	x86_64 Linux

Priority	high Severity high
Target Milestone:	rc
Target Release:	---
Assigned To:	Alex Jia
QA Contact:	Virtualization Bugs
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-30 06:44 EST by Alex Jia
Modified:	2012-06-20 02:40 EDT (History)
CC List:	7 users (show)

See Also:
Fixed In Version:	libvirt-0.9.10-1.el6
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2012-06-20 02:40:41 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
valgrind result (24.26 KB, text/plain) 2012-02-21 04:01 EST, zhpeng	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2012:0748	normal	SHIPPED_LIVE	Low: libvirt security, bug fix, and enhancement update	2012-06-19 15:31:38 EDT

Groups: None (edit)

Description Alex Jia 2011-12-30 06:44:58 EST

Description of problem:
Memory leak on libvirt_virDomainBlockStatsFlags API.

Version-Release number of selected component (if applicable):
libvirt-python-0.9.9-0rc1.el6.x86_64.rpm

How reproducible:
always

Steps to Reproduce:
1. Paste the following codes into test.py:

import libvirt
con = libvirt.open(None)
dom = con.lookupByName('foo')
dom.blockStatsFlags("/var/lib/libvirt/images/foo.img", 0)

2. valgrind -v --leak-check=full python test.py
  
Actual results:

==18725== 160 bytes in 5 blocks are definitely lost in loss record 1,525 of 2,083
==18725==    at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
==18725==    by 0x39E1A85EC3: PyObject_Malloc (obmalloc.c:935)
==18725==    by 0x39E1A77831: _PyLong_New (longobject.c:75)
==18725==    by 0x39E1A79EB6: PyLong_FromLongLong (longobject.c:864)
==18725==    by 0xB8FAD08: libvirt_virDomainBlockStatsFlags (libvirt-override.c:160)
==18725==    by 0x39E1ADE7F3: PyEval_EvalFrameEx (ceval.c:3794)
==18725==    by 0x39E1ADF99E: PyEval_EvalFrameEx (ceval.c:3880)
==18725==    by 0x39E1AE0466: PyEval_EvalCodeEx (ceval.c:3044)
==18725==    by 0x39E1AE0541: PyEval_EvalCode (ceval.c:545)
==18725==    by 0x39E1AFB88B: run_mod (pythonrun.c:1351)
==18725==    by 0x39E1AFB95F: PyRun_FileExFlags (pythonrun.c:1337)
==18725==    by 0x39E1AFCE4B: PyRun_SimpleFileExFlags (pythonrun.c:941)
==18725==
==18725== 258 bytes in 5 blocks are definitely lost in loss record 1,590 of 2,083
==18725==    at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
==18725==    by 0x39E1A85EC3: PyObject_Malloc (obmalloc.c:935)
==18725==    by 0x39E1A9053C: PyString_FromString (stringobject.c:138)
==18725==    by 0xB8FAD1C: libvirt_virDomainBlockStatsFlags (libvirt-override.c:177)
==18725==    by 0x39E1ADE7F3: PyEval_EvalFrameEx (ceval.c:3794)
==18725==    by 0x39E1ADF99E: PyEval_EvalFrameEx (ceval.c:3880)
==18725==    by 0x39E1AE0466: PyEval_EvalCodeEx (ceval.c:3044)
==18725==    by 0x39E1AE0541: PyEval_EvalCode (ceval.c:545)
==18725==    by 0x39E1AFB88B: run_mod (pythonrun.c:1351)
==18725==    by 0x39E1AFB95F: PyRun_FileExFlags (pythonrun.c:1337)
==18725==    by 0x39E1AFCE4B: PyRun_SimpleFileExFlags (pythonrun.c:941)
==18725==    by 0x39E1B094CE: Py_Main (main.c:577)


Expected results:
Fix memory leaks.

Additional info:

Comment 1 Alex Jia 2012-02-17 05:12:06 EST

The following patch has fixed the issue together, In POST:

commit 56cec18d761a1f99862c43811de60380c65881e6
Author: Guannan Ren <gren@redhat.com>
Date:   Fri Feb 10 18:17:26 2012 +0800

    python: make other APIs share common {get, set}PyVirTypedParameter
    
            *libvirt_virDomainBlockStatsFlags
            *libvirt_virDomainGetSchedulerParameters
            *libvirt_virDomainGetSchedulerParametersFlags
            *libvirt_virDomainSetSchedulerParameters
            *libvirt_virDomainSetSchedulerParametersFlags
            *libvirt_virDomainSetBlkioParameters
            *libvirt_virDomainGetBlkioParameters
            *libvirt_virDomainSetMemoryParameters
            *libvirt_virDomainGetMemoryParameters
            *libvirt_virDomainSetBlockIoTune
            *libvirt_virDomainGetBlockIoTune

Comment 2 Daniel Veillard 2012-02-21 03:12:49 EST

This made 0.9.10 release so should be fixed in libvirt-0.9.10-1.el6

Daniel

Comment 3 zhpeng 2012-02-21 04:00:27 EST

I tested this with:
libvirt-0.9.10-1.el6.x86_64

Test passed.

valgrind test result is attached.

Comment 4 zhpeng 2012-02-21 04:01:03 EST

Created attachment 564611 [details]
valgrind result

Comment 7 min zhan 2012-02-23 03:41:43 EST

Move it to VERIFIED per Comment 3 and Comment 4.

Comment 9 errata-xmlrpc 2012-06-20 02:40:41 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html

Note You need to log in before you can comment on or make changes to this bug.