Spec URL: http://kwizart.fedorapeople.org/review/libva-vdpau-driver.spec SRPM URL: http://kwizart.fedorapeople.org/review/libva-vdpau-driver-0.7.3-2.fc16.src.rpm Description: HW video decode support for VDPAU platforms This package is a bridge between vdpau and vaapi, there is no actual hardware back-end provided here. (instead a given back-end may rely on this package to HW decode a video stream from a VA-API enabled player) There seem to have proof of concept of a vdpau backend for an open source driver (untested yet) http://cgit.freedesktop.org/~emericg So that make the package interest to rise up for fedora itself.
Seems to miss %post and %postun sections required for libraries: https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
Hello Mattia and thanks for your interest in this review. This is a good remark, but actually this is a special case here. This library is not intended to be used 'system wide' but only from a dedicated library (libva), which last is installed with ldconfig. So libva is expected to 'dlopen' the right backend %name_drv_video.so from the special directory ( %_libdir/dri ) given the current driver used by the Xorg server. For the same reason, this is usually expected to have the shared object un-versioned in this case. So to sum-up, you can consider this library as a module or a plugin like the one provided by mesa-dri-drivers from the mesa case.
Spec URL: http://kwizart.fedorapeople.org/review/libva-vdpau-driver.spec SRPM URL: http://kwizart.fedorapeople.org/review/libva-vdpau-driver-0.7.4-1.fc19.src.rpm Description: HW video decode support for VDPAU platforms Changelog: Update to 0.7.4 Koji scratch build for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4833120 rpmlint is clean
Sounds like the package fails with recent mesa. I will probably ask upstream about a patch similar to this: http://gitorious.org/vaapi/gstreamer-vaapi/commit/5db2e93d3c930fd8470cfdcd26f514d1cebc59a0/diffs
(In reply to comment #4) > Sounds like the package fails with recent mesa. > I will probably ask upstream about a patch similar to this: > http://gitorious.org/vaapi/gstreamer-vaapi/commit/ > 5db2e93d3c930fd8470cfdcd26f514d1cebc59a0/diffs Gentoo seems to have applied similar patch to their package: https://bugs.gentoo.org/show_bug.cgi?id=438180
By the way, at least please make build.log more verbose so that we can check easily if Fedora specific compilation flags are honored correctly (just checked build.log only, not checked spec file or so yet)
Nicolas, would you try if gentoo patch works? If build gets successful, I may want to review this ticket.
Spec URL: http://kwizart.fedorapeople.org/review/libva-vdpau-driver.spec SRPM URL: http://kwizart.fedorapeople.org/review/libva-vdpau-driver-0.7.4-2.fc18.src.rpm Description: HW video decode support for VDPAU platforms Changelog: - Fix build with recent mesa The patch was sent upstream (no answear yet). koji scratch build for f18 http://koji.fedoraproject.org/koji/taskinfo?taskID=4874068
Taking. I would appreciate it if you would review my review request bug 902024 .
For 0.7.4-2: * Make build.log verbose - Currently build.log just shows --------------------------------------------------------- make[2]: Entering directory `/builddir/build/BUILD/libva-vdpau-driver-0.7.4/src' CC debug.lo CC object_heap.lo CC uasyncqueue.lo CC ulist.lo CC uqueue.lo CC utils.lo --------------------------------------------------------- and I cannot test some more detailed issues, for example if Fedora specific compilation flags are passed correctly or not. Please add "--disable-silent-rules" to %configure ! No longer needed items (not blockers) - The following items are no longer needed, unless you want to import this also on EPEL5. * BuildRoot: line * "rm -rf %{buildroot}" at the top of %install * %clean section * %defattr ! Note I don't know how to check if this driver works or not, so I just check packaging issues on this rpm.
ping?
I will probably have more time this week. (I will do your review)
Okay, thank you for response.
ping again?
Again ping?
Spec URL: http://kwizart.fedorapeople.org/review/libva-vdpau-driver.spec SRPM URL: http://kwizart.fedorapeople.org/review/libva-vdpau-driver-0.7.4-3.fc19.src.rpm Description: HW video decode support for VDPAU platforms Changelog: - Add --disable-silent-rules - Clean-up spec
For 0.7.4-3: * Directory ownership - It seems that it is better that this rpm has "Requires: mesa-dri-filesystem" for the ownership of %_libdir/dri . Please fix the above issue before importing this into git. ----------------------------------------------------- This package (libva-vdpau-driver) is APPROVED by mtasaka -----------------------------------------------------
Sorry, yes I will add Requires: mesa-dri-filesystem
New Package SCM Request ======================= Package Name: libva-vdpau-driver Short Description: HW video decode support for VDPAU platforms Owners: kwizart Branches: el6 f18 f17 InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: libva-vdpau-driver New Branches: f19 Owners: kwizart InitialCC: Sorry, I should have requested a f19 branch also