Spec URL: http://www.lesbg.com/jdieter/pykka.spec SRPM URL: http://www.lesbg.com/jdieter/pykka-0.13.0-1.fc16.src.rpm Description: The goal of Pykka is to provide easy to use concurrency abstractions for Python by using the actor model. Pykka provides an actor API with two different implementations: * ThreadingActor is built on the Python Standard Library's threading and Queue modules, and has no dependencies outside Python itself. It plays well together with non-actor threads. * GeventActor is built on the gevent library. gevent is a coroutine-based Python networking library that uses greenlet to provide a high-level synchronous API on top of libevent event loop. It is generally faster, but doesn't like playing with other threads. Much of the naming in Pykka is inspired by the Akka project which implements actors on the JVM. Though, Pykka does not aim to be a Python port of Akka.
$ rpmlint pykka.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ../RPMS/noarch/pykka-0.13.0-1.fc16.noarch.rpm pykka.noarch: W: spelling-error %description -l en_US gevent -> event, g event, gent pykka.noarch: W: spelling-error %description -l en_US coroutine -> co routine, co-routine, routine pykka.noarch: W: spelling-error %description -l en_US greenlet -> green let, green-let, greenbelt pykka.noarch: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment pykka.noarch: W: spelling-error %description -l en_US doesn -> does, does n 1 packages and 0 specfiles checked; 0 errors, 5 warnings. $ rpmlint ../SRPMS/pykka-0.13.0-1.fc16.src.rpm pykka.src: W: spelling-error %description -l en_US gevent -> event, g event, gent pykka.src: W: spelling-error %description -l en_US coroutine -> co routine, co-routine, routine pykka.src: W: spelling-error %description -l en_US greenlet -> green let, green-let, greenbelt pykka.src: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment pykka.src: W: spelling-error %description -l en_US doesn -> does, does n 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
Hi, I'm the upstream author of Pykka. I would just like to mention that Gevent is an optional dependency only needed if you use the "pykka.gevent" package. Pykka is useful without Gevent. Thanks!
Taking for review.
(In reply to comment #2) > Hi, > > I'm the upstream author of Pykka. > > I would just like to mention that Gevent is an optional dependency only > needed if you use the "pykka.gevent" package. Pykka is useful without Gevent. > Yes, but it is safe to have it in BuildRequires and require it at runtime. Another way would be to have to define a subpackage named pykka-gevent, which requires pykka and python-gevent. But I think don't let us make it more complicated as it's worth. We speak about requirements of some kilobytes, that's why I wouldn't think about such a way. Scratch build for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4420502 $ rpmlint -i -v * pykka.src: I: checking pykka.src: W: spelling-error %description -l en_US gevent -> event, g event, gent The value of this tag appears to be misspelled. Please double-check. pykka.src: W: spelling-error %description -l en_US coroutine -> co routine, co-routine, routine The value of this tag appears to be misspelled. Please double-check. pykka.src: W: spelling-error %description -l en_US greenlet -> green let, green-let, greenbelt The value of this tag appears to be misspelled. Please double-check. pykka.src: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment The value of this tag appears to be misspelled. Please double-check. pykka.src: W: spelling-error %description -l en_US doesn -> does, does n The value of this tag appears to be misspelled. Please double-check. pykka.src: I: checking-url http://jodal.github.com/pykka/ (timeout 10 seconds) pykka.src: I: checking-url http://github.com/jodal/pykka/tarball/v0.13 (timeout 10 seconds) pykka.noarch: I: checking pykka.noarch: W: spelling-error %description -l en_US gevent -> event, g event, gent The value of this tag appears to be misspelled. Please double-check. pykka.noarch: W: spelling-error %description -l en_US coroutine -> co routine, co-routine, routine The value of this tag appears to be misspelled. Please double-check. pykka.noarch: W: spelling-error %description -l en_US greenlet -> green let, green-let, greenbelt The value of this tag appears to be misspelled. Please double-check. pykka.noarch: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment The value of this tag appears to be misspelled. Please double-check. pykka.noarch: W: spelling-error %description -l en_US doesn -> does, does n The value of this tag appears to be misspelled. Please double-check. pykka.noarch: I: checking-url http://jodal.github.com/pykka/ (timeout 10 seconds) pykka.spec: I: checking-url http://github.com/jodal/pykka/tarball/v0.13 (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 10 warnings. A few spelling errors which could be safely ignored. CFLAGS="$RPM_OPT_FLAGS" is superfluous here, because there's no C code included. If you don't want to provide it for EPEL 5, drop BuildRoot, the initial cleaning of %{buildroot} in %install, the %clean section and the %defattr line from %files. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. ASL 2.0 [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum * 81a4fe294489e53269509a135d856a669bb9e8374815d96faae5e8b797bb3941 v0.13.orig 81a4fe294489e53269509a135d856a669bb9e8374815d96faae5e8b797bb3941 v0.13 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [.] MUST: Development files must be in a -devel package. [.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses Mock anyway). [.] SHOULD: The package should compile and build into binary rpms on all supported architectures. [.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [+] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. ---------------- PACKAGE APPROVED ---------------- Please don't forget to fix the issues mentioned above before you import the package into the Git.
(In reply to comment #4) > pykka.src: I: checking-url http://jodal.github.com/pykka/ (timeout 10 > seconds) The website was moved to http://pykka.readthedocs.org/ some time ago. > pykka.src: I: checking-url http://github.com/jodal/pykka/tarball/v0.13 > (timeout 10 seconds) v0.15 has been released, so you may consider updating the package.
(In reply to comment #4) > CFLAGS="$RPM_OPT_FLAGS" is superfluous here, because there's no C code > included. > > If you don't want to provide it for EPEL 5, drop BuildRoot, the initial > cleaning of %{buildroot} in %install, the %clean section and the %defattr > line from %files. Mario, thanks for the review. I'll push out a new release fixing the items mentioned above, probably tomorrow. Stein, I will make sure the new release is based on the latest version and update the package website url.
Updated release: Spec URL: http://lesloueizeh.com/jdieter/pykka.spec SRPM URL: http://lesloueizeh.com/jdieter/pykka-0.15-1.fc17.src.rpm
I don't know what just happened, but this bug somehow got its component changed, flags reset, and assigned to a different user. I've reset the component and assigned it back to you, Mario, but you'll need to set the review flag yourself, I think.
I have to set fedora-review+ once the package has been approved by me. Perhaps a bug in Bugzilla itself? Doesn't matter, all is fine again, go ahead.
Um, fedora-review+ seems to have been unset so my scm request won't go through. Do you mind setting the fedora-review+ flag again? Thanks.
(In reply to comment #10) > Do you mind setting the fedora-review+ flag again? Thanks. Done.
New Package SCM Request ======================= Package Name: pykka Short Description: Python library that provides concurrency using actor model Owners: jdieter Branches: f16 f17 f18 el6 InitialCC:
You haven't requested a Git branch for el5, that's why please don't forget to drop the appropriate stuff from your spec before importing it. Means BuildRoot tag, %clean section and so on.
Sorry, I missed the buildroot tag, though I think I got the %clean section and others you mentioned. Here's another release without the buildroot tag. Updated release: Spec URL: http://lesloueizeh.com/jdieter/pykka.spec SRPM URL: http://lesloueizeh.com/jdieter/pykka-0.15-2.fc17.src.rpm
Git done (by process-git-requests).
OK, looks fine. Use this for the Git import.
pykka-0.15-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pykka-0.15-2.fc18
pykka-0.15-2.fc18 has been pushed to the Fedora 18 testing repository.
pykka-0.15-2.fc18 has been pushed to the Fedora 18 stable repository.