Description of problem: Clementine released version 1.0 27th of December[1] 2011, are are even providing RPMs[2]. The version now provided by Fedora is 0.7, released March 2011. Clementine was an item of the "Changes in Fedora for Desktop users" in Fedora 14 [3]. [1]: http://www.clementine-player.org/about [2]: http://www.clementine-player.org/downloads [3]: http://docs.fedoraproject.org/en-US/Fedora/14/html/Release_Notes/sect-Release_Notes-Changes_for_Desktop_Users.html
Thanks for the heads up. Unfortunately, clementine bundles a bunch of external libraries. Fedora policies dictate that the bundled libraries must be patched out and instead, the application must use the system libraries. If the bundled libraries don't exist in Fedora, they need to be packaged. For the time being I don't really know how much work it is to update to 1.0. I'll post my comments here once I have an idea how long this will take.
Btw, there is a RPM for Fedora on the project webpage. It seems that 1.0.0 uses only protobuf in addition to dependencies already installed by version 0.7.1 from Fedora repository.
clementine-1.0.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/clementine-1.0.1-1.fc16
Here we go, after some work patching out the bundled libraries (sha2 and echogen, the latter was dropped by upstream on 1.0.1), I submitted an update on F-16. Please test and see how things go.
I would test it, but still have Fedora 15. Would you also merge changes into F15 branch?
And generally thanks for the update!
Package clementine-1.0.1-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing clementine-1.0.1-1.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-1311/clementine-1.0.1-1.fc16 then log in and leave karma (feedback).
Marcin, Fedora 15 is at a mature state now, and it has 4 months of lifetime left. Yet I would love to make the update. However the Fedora policies explicitly discourage package maintainers to do major version updates in mature branches. Please feel free to bring your concerns to the steering committee. Anyhow I see that our Fedora 15 clementine-0.7.1 package did not get all the bugfix updates that the other branches did. I think I can do a bugfix update on Fedora 15.
No problem with that. I will rebuild clementine from SRPM for my Fedora 15. I see I have to reread current Fedora policies. In the past I put all my important updates in all currently maintained branches/versions (in Fedora - EPEL had more strict update policy).
Created attachment 559704 [details] spec file that ships plasma widget separately from main package since clementine has no dependencies on KDE, plasma widget could be shipped apart and allow both KDE and non-KDE users to enjoy clementine. adds a conditional --without kde for people who wants to rebuild src.rpm without kde bits.
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3766356 Such updates that brings new dependencies (kdelibs is no trivial dependencies) should be carefully considered before being pushed into stable release. Since, the plasma widget could be shipped separately, i suggest that you do so (at least on stable releases so that non-KDE users don't wake up with such a bad surprise).
Thanks Haïkel for the patch. Just a correction, the KDE extension here is not a plasmoid, it is actually a runner (alt+f2 shortcut for certain actions, in this case it is for library search). I don't believe that clementine depending on some KDE libraries is something terrible. After all, clementine is based on amarok-1.4, right? However I agree that such a change in dependency chain should not happen in a stable Fedora release. We might as well exclude the KDE extensions from the clementine RPM until Fedora 17, as I don't want to divide this package into pieces. Let me talk to KDE packagers and have their opinion.
After looking at Haïkel's patch it seems to be technically possible to simple exclude KDE dependent part to a separate package to be able to install it when needed. As a Gnome user it's very convenient for me. I don't need to load KDE libs for a feature that will not use. Currently Clementine is generally a QT app which is just fine for Gnome (also XFCE and LXDE) users. Merging KDE dependent part into the main clementine package would force Gnome users to rebuild it from SRPM to not load KDE libs at startup. I don't know why a separate package would be such a big problem for KDE users?
The problem is that such a subpackage can easily get missed/forgotten. Since this application is written in Qt, I believe having some KDE library dependency will not hurt. There is no need to get scared of some KDE library, even if you are a Qt user. I think we are at a point where the choice is at the package maintainer's discretion. I am just trying to find the optimal solution.
> Since this application is written in Qt, I believe having some KDE library dependency will not hurt I may disagree since a Qt application is not necessarily a KDE application. What I (and probably other people) liked with Clementine is that it was a standalone Qt application unlike Amarok 1.4.x which did requires kdelibs. Since Qt 4.5, Qt applications did very well integrating in Gtk+ based environment, and it allowed people using minimal environments such as windows managers to get a full featured player without any bloat. My 2 cts. If you think that KDE integration should be provided in the main package from F17 onwards, another alternative would be to keep the main clementine package with the plasmoid and have it requiring a clementine-qt subpackage containing the player. Whatever is your decision as maintainer, i will respect it. :]
Thanks for the advise. Actually that is not a bad idea either. By the way it looks like bug #773547 came back with this 1.0.1-1 update. I have to reintroduce the same patch.
Package clementine-1.0.1-2.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing clementine-1.0.1-2.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-1311/clementine-1.0.1-2.fc16 then log in and leave karma (feedback).
clementine-1.0.1-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.