The infiniband-diags package provides a number of utilities for querying the state of an InfiniBand fabric. It can get the detailed information on any given port on the fabric for diagnostic purposes.
I suggest that a devel and devel-static are added for this package: %description devel Header files for the infiniband-diags library. %package devel-static Summary: Static development files for the infiniband-diags library Group: System Environment/Libraries Requires: %{name}-devel = %{version}-%{release} %description devel-static Static libraries for the infiniband-diags library. %files devel %defattr(-,root,root,-) %{_libdir}/lib*.so %{_includedir}/infiniband/* %{_mandir}/man3/* %files devel-static %defattr(-,root,root,-) %{_libdir}/*.a The ibnetdisc library that is part of this package is very useful when writing custom admin tools.
$ rpmlint infiniband-diags.spec infiniband-diags.spec:12: W: unversioned-explicit-provides perl(IBswcountlimits) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpmlint infiniband-diags-1.5.12-1.fc15.x86_64.rpm infiniband-diags.x86_64: W: spelling-error %description -l en_US subnet -> subset, sublet, sub net infiniband-diags.x86_64: W: obsolete-not-provided openib-diags infiniband-diags.x86_64: W: non-conffile-in-etc /etc/infiniband-diags/error_thresholds infiniband-diags.x86_64: W: no-manual-page-for-binary check_lft_balance.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibdiscover.pl infiniband-diags.x86_64: W: no-manual-page-for-binary dump_mfts.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibqueryerrors.pl infiniband-diags.x86_64: W: no-manual-page-for-binary dump_lfts.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibswportwatch.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibfindnodesusing.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintca.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintswitch.pl infiniband-diags.x86_64: W: no-manual-page-for-binary iblinkinfo.pl infiniband-diags.x86_64: W: no-manual-page-for-binary set_nodedesc.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibidsverify.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintrt.pl 1 packages and 0 specfiles checked; 0 errors, 16 warnings. Looks like the file in sysconfdir needs a %config(noreplace). I noticed on the linux-rdma mailing list that these scripts aren't supported anymore: http://www.spinics.net/lists/linux-rdma/msg10669.html Do we want to package them?
New files (although with the same n-v-r) uploaded to my package page listed in the URL above that address the comments.
Package looks good. Thanks. Does anything else need to be done to finish the review?
The reviewer needs to set the fedora-cvs flag I think, and then the rel-eng people will create a cvs (git now, but the flag name hasn't changed) module and create the appropriate branches and then possibly import the srpm into the git repo, or something like that. I'm a bit fuzzy on the process myself as I don't do it all that often.
My mistake, now that you've approved it, it's up to me to do the request.
Except that the way you are supposed to signify that it has passed your review is setting the fedora-review flag to +, then I can proceed with making the request for package addition.
It seems I can't set fedora-review flag to +... my only option is ?. I guess I need to get sponsored, which is quite hard, given that I haven't contributed a package.
Yep, that would be a problem ;-) I've asked one of my co workers to take a look.
New Package SCM Request ======================= Package Name: infiniband-diags Short Description: Tools to query and diagnose InfiniBand physical networks Owners: dledford Branches: f15 f16 InitialCC:
Git done (by process-git-requests).
infiniband-diags-1.5.12-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/infiniband-diags-1.5.12-1.fc16
infiniband-diags-1.5.12-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/infiniband-diags-1.5.12-1.fc15
infiniband-diags-1.5.12-1.fc15 has been pushed to the Fedora 15 testing repository.
infiniband-diags-1.5.12-1.fc16 has been pushed to the Fedora 16 stable repository.
infiniband-diags-1.5.12-1.fc15 has been pushed to the Fedora 15 stable repository.