Bug 773051 - RFE: During image creation, disable "Automatically make <image> deployable" when no catalogs are defined
Summary: RFE: During image creation, disable "Automatically make <image> deployable" w...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: CloudForms Cloud Engine
Classification: Retired
Component: aeolus-conductor
Version: 1.0.0
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: rc
Assignee: Jiri Tomasek
QA Contact: wes hayutin
URL:
Whiteboard:
: 785010 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-10 19:08 UTC by Gabriel Szasz
Modified: 2012-05-15 21:33 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-15 21:33:59 UTC


Attachments (Terms of Use)
Screenshot of the final error message (127.40 KB, image/png)
2012-01-10 19:08 UTC, Gabriel Szasz
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2012:0583 0 normal SHIPPED_LIVE new packages: aeolus-conductor 2012-05-15 22:31:59 UTC

Description Gabriel Szasz 2012-01-10 19:08:01 UTC
Created attachment 551917 [details]
Screenshot of the final error message

Description of problem:

Deployment of an image fails with confusing error message, if there is no catalog created.


Version-Release number of selected component (if applicable):

0.8.0-2


How reproducible:

Bug is easy to reproduce.


Preliminary steps:
1. Install aeolus-all-0.8.0-2.el6 on RHEL 6.2
2. Turn off SELinux Enforcing mode and update the firewall.
3. Run /usr/sbin/aeolus-configure -p ec2,mock
4. Log into the Web UI.
5. Setup Amazon EC2 credentials.


Steps to Reproduce:
1. Click on card "Administer" in the Web UI
2. Click on "Environments"
3. Click on "New Image" in "default" pool family.
4. Write arbitrary string into the "Name" entry field.
5. Add any valid a template file by "Choose a template file" entry (e.g. example template from the online documentation).
6. Click on "Continue"
7. Click on "Save and Continue"
8. Click on "Save Template"
9. Click on "Save"

  
Actual results:

Getting following two confusing messages (see attachment):
* "Deployable added"
* "Deployable was not created: No route matches {:action=>"show", :controller=>"catalogs"}"


Expected results:

I would expect an error message right after the step 3 that prevents user to proceed up to step 9.


Additional info:

There is no catalog available in the fresh installation of Aeolus and new image can be no way added in such circumstances. That is the reason why user should never get beyond step 3 if there is no catalog created.

Suggested fixes:
* Add a check for the number of catalogs available and do not let user to go beyond step 3 in case if number of catalogs is lower than 1.
* Alternatively, the configure script can preventively create the "default" catalog

Comment 1 wes hayutin 2012-01-12 16:53:11 UTC
adding to sprint tracker

Comment 2 Mike Orazi 2012-01-13 15:39:19 UTC
We will address this by ensuring that aeolus-configure creates a default catalog.

*** This bug has been marked as a duplicate of bug 781474 ***

Comment 3 James Laska 2012-01-17 13:19:53 UTC
Bug#781474 discusses having a catalog created by default by aeolus-configure.  As I understand, this works around this problem, but doesn't address it.

If the user chooses to delete all catalogs, they are open to the this problem.  I believe this bug should prevent the user from entering a new image if no catalogs exist.

I propose decoupling this as a DUPLICATE bug

Comment 4 Mike Orazi 2012-01-17 20:19:41 UTC
I think I mentioned the same concern in the initial conversation where we decided to dupe it.  I'm not opposed to tracking this separately as a distinct issue.

Comment 5 James Laska 2012-01-17 21:07:47 UTC
(In reply to comment #4)
> I think I mentioned the same concern in the initial conversation where we
> decided to dupe it.  I'm not opposed to tracking this separately as a distinct
> issue.

Thanks Mike ... I'm opening this backup.  

Sounds like the urgency of this problem will be mitigated by creating a default catalog upon running aeolus-configure (bug#781474).  However, the user is still exposed to shooting themselves in the foot and removing all catalogs.

With no catalog created, the user is allowed to create an image. During image creation, if the user accepts the default-selected option ([X] Automatically make "client2" deployable), they are able to ...
 1. Successfully create the image
 2. Fail to create the deployable

I think this bug should be repurposed to disable the option "Automatically make "client2" deployable."  if there are no catalogs defined.

Thoughts/concerns?

Comment 6 Dave Maley 2012-01-27 17:09:26 UTC
*** Bug 785010 has been marked as a duplicate of this bug. ***

Comment 7 Jiri Tomasek 2012-02-02 09:56:15 UTC
fix has been posted on aeolus-devel.org
https://fedorahosted.org/pipermail/aeolus-devel/2012-February/008536.html

Comment 8 Jiri Tomasek 2012-02-06 14:58:40 UTC
commit 8a80b0f785e0c5e4c510e875cf8443b62d5671a0 solved this issue as it redesigns image creation workflow, so the bug is not present any more. Previously posted fix is obsolete now.

Comment 9 Steve Linabery 2012-02-14 18:49:37 UTC
8a80b0f in aeolus-conductor-0.8.0-27

Comment 10 Rehana 2012-02-24 13:38:48 UTC
Verified this bug:

The fix has removed the "Automatically make "name" deployable" feature when you upload(upload,from URL) a component outline from UI even if the catalog is present.

So now the issue has been resolved.if no catalogs are present User is displayed with this "No catalog exists! Please create one."message during deployable creation.

info:

[root@nec-em25 html]# rpm -qa | grep aeolus
rubygem-aeolus-image-0.3.0-10.el6.noarch
aeolus-conductor-daemons-0.8.0-36.el6.noarch
aeolus-conductor-doc-0.8.0-36.el6.noarch
aeolus-configure-2.5.0-15.el6.noarch
rubygem-aeolus-cli-0.3.0-10.el6.noarch
aeolus-all-0.8.0-36.el6.noarch
aeolus-conductor-0.8.0-36.el6.noarch

Comment 11 errata-xmlrpc 2012-05-15 21:33:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-0583.html


Note You need to log in before you can comment on or make changes to this bug.