Bug 773344 - repo delete failure when repo clone not found.
Summary: repo delete failure when repo clone not found.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: user-experience
Version: 1.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Sayli Karmarkar
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-11 15:25 UTC by Preethi Thomas
Modified: 2015-03-23 01:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-24 20:12:54 UTC


Attachments (Terms of Use)

Description Preethi Thomas 2012-01-11 15:25:38 UTC
Description of problem:
repo delete fails if there is a repos in there are cloned repos but if the repos doesn't exist.

I had a repo (f15) I cloned, but I did a cancel clone which failed to cancel it completely. 
The cloned repo didn't get created but it still showed the following in the repo that was being cloned.

Clones             	[u'f15-clone', u'f15-clone1']

Related bug for this state is 

https://bugzilla.redhat.com/show_bug.cgi?id=760601

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. created f15 repo and synced
2. run repo clone
3.run cancel_clone at the end
4. repo list doesn't show the cloned repo but  the original repo shows the cloned repo
Clones             	[u'f15-clone', u'f15-clone1']

5. Try to delete the original repo (f15)
see the repo being deleted message

see the following in the pulp.log
and you can see that the repo does not get deleted

  
Actual results:
2012-01-11 10:12:00,956 10841:140055452575488: pulp.server.api.repo:INFO: repo:527 Delete API call invoked f15
2012-01-11 10:12:03,485 10841:140055452575488: pulp.server.tasking.task:ERROR: task:455 Task failed: Task 9a50fb66-3c66-11e1-92bb-002564a85a58: RepoApi.delete(, id=f15)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/pulp/server/tasking/task.py", line 404, in run
    result = self.callable(*self.args, **self.kwargs)
  File "/usr/lib/python2.7/site-packages/pulp/server/api/repo.py", line 541, in delete
    cloned_repo = self._get_existing_repo(clone_id)
  File "/usr/lib/python2.7/site-packages/pulp/server/api/repo.py", line 116, in _get_existing_repo
    raise PulpException("No Repo with id: %s found" % id)
PulpException: No Repo with id: f15-clone found


Expected results:


Additional info:

Comment 1 Sayli Karmarkar 2012-01-13 19:50:07 UTC
commit ba6d209544f0155facefe4e709ca7ac490947e4e
Author: Sayli Karmarkar <skarmark>
Date:   Fri Jan 13 11:49:08 2012 -0800

    773344 - fixed repo delete failure for non existing clone ids by adding exception handling

Added unit test as well to avoid regressions.

Comment 2 Jeff Ortel 2012-01-16 22:47:57 UTC
build: 0.258

Comment 3 Preethi Thomas 2012-01-20 17:15:16 UTC
verified
[root@preethi ~]# rpm -q pulp
pulp-0.0.258-1.fc15.noarch
[root@preethi ~]#

Comment 4 Preethi Thomas 2012-02-24 20:12:54 UTC
Pulp v1.0 is released
Closed Current Release.


Note You need to log in before you can comment on or make changes to this bug.