Hide Forgot
Spec URL: http://kwizart.fedorapeople.org/review/intel-gen4asm.spec SRPM URL: http://kwizart.fedorapeople.org/review/intel-gen4asm-1.2-1.fc16.src.rpm Description: Compile an assembly language for the Intel 965 This package is needed to regenerate the Intel ASM used on severals intel GPU component (such as libva-intel-driver).
Only useful on Intel Arches ExclusiveArch: %{ix86} x86_64 ia64
Spec URL: http://kwizart.fedorapeople.org/review/intel-gen4asm.spec SRPM URL: http://kwizart.fedorapeople.org/review/intel-gen4asm-1.3-1.fc19.src.rpm Description: Compile an assembly language for the Intel 965 Changelog: Update to 1.3 Koji rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4836034
Confirmed that at least this builds on F-18 koji build and can be installed. Taking. I would appreciate it if you would review my review request bug 875353.
For 1.3-1 * No longer needed bits - "BuildRoot: %{_tmppath}..." line, "rm -rf $RPM_BUILD_ROOT" at the beginning of %install, the whole %clean section are no longer needed (on Fedora 19/18/17 and RHEL6: RHEL5 still need these item) https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean ? Installed pkgconfig file - As this binary rpm seems somewhat meant for development purpose, I don't make it a blocker that pkgconfig file is included in the main package. However looking at installed pkgconfig file, it seems essentially empty (it contains some basic information and does not contain Libs or Cflags information). Is this pkgconfig file really needed? * Executing tests - As this package contains test/ directory and test/run-test.sh script, please enable %check section and execute some test program if possible. * isa specific dependency - I don't know on which branches (may be EPEL5?) isa is not defined, however currently it is best to use %{?isa} instead of %{isa} (where isa may not be defined) ! Also please check the above "Installed pkgconfig file" section.
(In reply to comment #4) > For 1.3-1 > > * No longer needed bits fixed > > ? Installed pkgconfig file libva-intel-driver (still forbidden in fedora) rely on this pc file: PKG_CHECK_MODULES(GEN4ASM, [intel-gen4asm >= 1.3], [gen4asm=yes], [gen4asm=no]) > * Executing tests > - As this package contains test/ directory and test/run-test.sh > script, please enable %check section and execute some > test program if possible. I will add this. > * isa specific dependency Fixed. I don't plan to build for EPEL-5 in this case. Thx
For test: - It seems that just adding -------------------------------------------- %check cd test sh ./run-test.sh -------------------------------------------- will do some test suite (currently run-test.sh does not check the returned value of each test, however at least you can check if test passes or not when you check build log) Please consider to add above, however no blockers -------------------------------------------------------- This package (intel-gen4asm) is APPROVED by mtasaka --------------------------------------------------------
New Package SCM Request ======================= Package Name: intel-gen4asm Short Description: Compile an assembly language for the Intel 965 Owners: kwizart Branches: f17 f18 el6 InitialCC:
Git done (by process-git-requests).