Bug 777544 (SOA-45) - execute the full range of tests in drools-compiler inside the SOA environment
Summary: execute the full range of tests in drools-compiler inside the SOA environment
Keywords:
Status: CLOSED NEXTRELEASE
Alias: SOA-45
Product: JBoss Enterprise SOA Platform 4
Classification: JBoss
Component: JBoss Rules
Version: 4.2 CP01
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.3 GA
Assignee: trev
QA Contact:
URL: http://jira.jboss.org/jira/browse/SOA-45
Whiteboard:
Depends On: SOA-243 SOA-336
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-10-08 21:08 UTC by Mark Proctor
Modified: 2008-10-28 08:07 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-10-28 08:07:29 UTC
Type: Task


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 777968 0 high CLOSED JBoss Rules regression with JANINO 2021-02-22 00:41:40 UTC
Red Hat Issue Tracker SOA-45 0 None None None Never

Internal Links: 777968

Description Mark Proctor 2007-10-08 21:08:27 UTC
Date of First Response: 2007-10-31 18:05:58
project_key: SOA

drools-compiler has a large range of integration tests, attempts should be made to execute all of these.

Comment 2 Jaroslaw Kijanowski 2007-11-02 12:04:19 UTC
yes, we're working on this with AlexK

Comment 3 Jaroslaw Kijanowski 2007-11-02 12:08:23 UTC
Link: Added: This issue is related to JBQA-852


Comment 4 Jaroslaw Kijanowski 2007-11-14 15:17:38 UTC
please see 
http://hudson.qa.jboss.com/hudson/view/SOA/job/drools-4.0.2_SOA-4.2_branch/

Mark, can you verify we run all necessary tests against the SOA-P drools bits?

http://hudson.qa.jboss.com/hudson/view/SOA/job/drools-4.0.2_SOA-4.2_branch/64/testReport/

Comment 5 Mark Proctor 2007-11-15 15:53:14 UTC
I'm going to assign fernando for 2 weeks full time to the soa platform stuff, he will do all remaining tests and verify this for you.

Comment 6 Jaroslaw Kijanowski 2007-11-15 16:49:10 UTC
what do you mean by "all remaining tests", can you point to any jiras? Are these new tests? What kind of tests?

BTW, in my comment above, by "all necessary tests", I meant all necessary tests included in the native drools testsuite.

Comment 7 Jaroslaw Kijanowski 2007-11-19 15:59:27 UTC
Hi Mark,
 any comments on this jira?

Comment 8 Mark Proctor 2007-11-20 09:27:18 UTC
Fernando will be doing stuff like JBossWS testing.

As far as I can tell you are not running anything against SOA-P, you are just running a drools branch that we made for SOA-P, so I'm not sure what it is you wish me to confirm? Its executing 1408 tests compared to 1968 in 4.0.x - but as far as I can tell that is only due to SOA-P not build eclipse.

Comment 9 Jaroslaw Kijanowski 2007-11-20 17:22:30 UTC
My fault! The URL above is a hudson job we set up only to compile tests jars needed for the drools testsuite.

http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite-single/82/testReport/ is the job, which runs the testsuite from http://anonsvn.labs.jboss.com/labs/jbossrules/branches/Branch_4_0_2_SOA_4_2/ against the drools bits shipped with SOA-P.



Comment 10 Jaroslaw Kijanowski 2007-11-22 10:17:12 UTC
Below is an URL to results for running the testsuite against the current SOA-P bits:

http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite-single/93/testReport/

All errors will go away, when we use finally the correct drools bits in SOA-P, beside two issues which come up only when using JANINO:
Could you please have a look at them?

http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite-single/93/testReport/org.drools.compiler/Java5Test(JANINO)/testJava5Rule/
http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite-single/93/testReport/org.drools.integrationtests/MiscTest(JANINO)/testWithInvalidRule/

Thanks

Comment 11 Fernando Meyer 2007-12-17 12:40:32 UTC
According the latest test the configuration isn't founding janino library, could someone take a look or help me with?
http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite-single/95/ 



Comment 12 Fernando Meyer 2007-12-18 03:19:45 UTC
Jarek, 

I found the problem, both ESB and EAP are using an old mvel version mvel14-1.2rc4rv908.jar when drools depends of latest mvel14-1.2.8.jar

Fernando

Comment 13 Jaroslaw Kijanowski 2007-12-18 10:42:04 UTC
Link: Added: This issue depends SOA-243


Comment 14 Fernando Meyer 2007-12-18 19:03:33 UTC
Waiting for http://jira.jboss.com/jira/browse/SOA-242 and http://jira.jboss.com/jira/browse/SOA-243 to finish this test
Locally after update these libs tests execute with no erros 

Comment 16 Fernando Meyer 2008-01-02 18:42:35 UTC
Java5Test is Fixed, PackageBuilder should receive the configuration as a constructor parameter To test against eclipse, janino doesn't support J2SE 5.0: Enhanced FOR loop

MiscTest.testWithInvalidRule: I found a problem in janino when we use $variable, janino tries to tokenize as an innerClass, will open a ticket in janino's jira





Comment 17 Jaroslaw Kijanowski 2008-01-04 11:51:11 UTC
Nice!
http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite-single/109/testReport/

I'm closing this jira.

Comment 18 Jaroslaw Kijanowski 2008-01-07 11:43:31 UTC
A run on a win box shows 4 errors:
http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite/8/label=Win2k3_x86/testReport/

However they seem to be transient, the next run showed only 3 of those 4 errors:
http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite/label=Win2k3_x86/9/testReport/

Comment 19 Aleksandar Kostadinov 2008-01-07 12:15:26 UTC
RHEL4 once failed http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite/label=RHEL4_x86/9/testReport/

RHEL5 once failed http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite/label=RHEL5_x86/10/testReport/

Odd that it seems issue is not much hardware dependent:
The RHEL5 tests failed once on 2 hyperthreading CPU box and didn't on  HW similar to that of the windows machine (2 dual-core CPUs)
The RHEL4 tests failed once on a vmware guest and passed many times on vmware guests and a dual CPU box (single-core hyper-threading).
The windows tests always failed on the 2 CPU dual-core box (not tested on other HW).

Comment 20 Michael Neale 2008-01-07 12:53:11 UTC
This looks like a (obviously intermittent ) race condition with the mvel dialect (I have seen it sometimes on my laptop). 

Comment 21 Mark Proctor 2008-01-07 13:18:48 UTC
yes  I think so too. Mike Brock says it's the enhancements that I made to MVEL for the foreach loop that might be it, but I have no idea how to fix it. Now that it's showing up in SOA-P hopefully he'll look over it for us.

Comment 22 Michael Neale 2008-01-07 23:26:54 UTC
OK apparently there is a new MVEL version out that fixes this (thanks to Mike Brock). 1.2.20. 

Comment 23 Fernando Meyer 2008-01-09 13:15:58 UTC
cbrock fixed mvel so variables cannot be defined twice, that test has invalid MVEL code that wasn't picked up on before I'm reviewing test sources and will check it again

Comment 24 Fernando Meyer 2008-01-09 15:24:42 UTC
According Jaroslaw we still have thread safety issues on windows machines

http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite/17/label=Win2k3_x86/testReport/

Comment 25 Fernando Meyer 2008-01-10 16:31:12 UTC
the variables cannot be defined twice was corrected on the drools-soa branch 

Comment 26 Mark Little 2008-01-23 08:18:40 UTC
What is the status of this issue?

Comment 27 Jaroslaw Kijanowski 2008-01-23 08:35:49 UTC
Will provide a status today... there are some hudson issues which needs to be fixed.

Comment 29 Len DiMaggio 2008-01-30 15:56:42 UTC
Is there a JIRA for the failed tests?


Comment 30 Jaroslaw Kijanowski 2008-01-30 16:11:34 UTC
There are a couple of them, SOA-336, SOA-337 and some others which fix the errors reported in hudson. AFAIK, the latest errors in testThreadSafetyEclipse have also been fixed (CR2), don't know the jira, maybe Fernando will know.

Comment 31 Fernando Meyer 2008-01-30 16:48:06 UTC
Link: Added: This issue depends SOA-336


Comment 32 Len DiMaggio 2008-01-31 16:28:59 UTC
According to Fernando - these are the ONLY TWO bugs resulting:

            SOA-336, SOA-337



Comment 33 Fernando Meyer 2008-01-31 16:41:40 UTC
about soa-45 the issue was on thread safety issue that cbrock fixes with the latest mvel version with the new version we must update the mvel templates on drools, that what those issues are related to

Comment 34 Jaroslaw Kijanowski 2008-02-05 07:02:49 UTC
status for CR2:

http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite/28/

org.drools.integrationtests.PackageBuilderThreadSafetyTest is still failing on windows: 

http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-rules-testsuite/label=Win2k3_x86/28/testReport/



Comment 35 Aleksandar Kostadinov 2008-04-07 09:01:29 UTC
Link: Added: This issue is related to SOA-497


Comment 36 Mark Little 2008-05-15 19:51:30 UTC
Fernando no longer works for us.

Comment 37 Jaroslaw Kijanowski 2008-07-14 07:03:39 UTC
This can be closed, see http://intranet.corp.redhat.com/ic/intranet/SOAP42JBossRulesTestsuite.html  for detailed description of all drools testsuites.

PackageBuilderThreadSafetyTest is fixed, all other issues are logged in jira.

Comment 38 Jiri Pechanec 2008-10-28 08:07:29 UTC
Running in Hudson


Note You need to log in before you can comment on or make changes to this bug.