Bug 780043 (SOA-2406) - [JBPM-2958] Timer should refer to the business calendar used at the time of creation
Summary: [JBPM-2958] Timer should refer to the business calendar used at the time of c...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: SOA-2406
Product: JBoss Enterprise SOA Platform 5
Classification: JBoss
Component: Documentation, JBPM - within SOA, JBPM - standalone
Version: 5.0.2
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
: 5.2.0 GA
Assignee: David Le Sage
QA Contact:
URL: http://jira.jboss.org/jira/browse/SOA...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-12 04:33 UTC by Toshiya Kobayashi
Modified: 2011-11-15 08:57 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-15 08:57:29 UTC
Type: Bug


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker SOA-2406 0 None None None Never

Description Toshiya Kobayashi 2010-10-12 04:33:11 UTC
Affects: Release Notes
Help Desk Ticket Reference: https://c.na7.visual.force.com/apex/Case_View?id=500A00000044dh5&sfdc.override=1
project_key: SOA

Platform JIRA for [JBPM-2958] Timer should refer to the business calendar used at the time of creation

Comment 1 Toshiya Kobayashi 2010-10-12 04:34:21 UTC
Link: Added: This issue incorporates JBPM-2958


Comment 2 Alejandro Guizar 2010-10-17 08:38:00 UTC
Project issue JBPM-2958 resolved. Because resolution requires an new database column, the update will have no noticeable effect unless enabled by replacing the mapping resource Timer.hbm.xml with Timer.calendar.hbm.xml in the Hibernate configuration file. Apart from that, a varchar column named CALENDARRESOURCE_ must be added to the JBPM_JOB table manually.

This procedure should be documented in the same vein as the Join Lock Mode extension, in the community wiki and out of the product manual, to avoid proliferation of nonstandard installations.
http://community.jboss.org/wiki/jBPM3JoinLockMode

Comment 3 Julian Coleman 2010-10-17 14:50:43 UTC
This change requires an upgrade script to be shipped with 5.1.0.GA.

Comment 4 Anne-Louise Tangring 2010-10-27 17:25:25 UTC
Accepted for 5.1

Comment 5 Jiri Pechanec 2010-11-09 16:26:09 UTC
This is not the proper solution - we have to distribute only one file - with fixed issue and provide the upgrade script for customers to upgrade to latest db.
Otherwise there is a risk that customer will create a new db using sql scripts provided that lacks bugfix and then switch hbm file when meet the bug which in turn means that db won't get updated and jBPM can go mad.


Comment 7 Len DiMaggio 2010-11-09 16:49:51 UTC
Affects Testing: Added: [Blocks Testing]
Blocked Tests: Added: Blocks jBPM testing


Comment 10 Alejandro Guizar 2010-11-10 04:48:08 UTC
The criteria an existing customer would use to decide whether they should apply this update is the following:
1. Repeating timers are in use, and repeat intervals are expressed in "business" time.
2. Multiple business calendar configuration files are in use.
3. The repeat date for a timer is being incorrectly calculated because the job executor only reads the business calendar resource specified in jbpm.cfg.xml.

Comment 13 Alejandro Guizar 2010-11-11 19:43:23 UTC
> QE to verify both timers.

The jBPM3 test suite runs all tests with Timer.hbm.xml, except for one specific test case, TimerCalendarTest. This test uses Timer.calendar.hbm.xml and adds the new column to the database if necessary. I believe this covers the QE requirement.

Comment 14 Anne-Louise Tangring 2010-12-02 15:28:09 UTC
PM team decided this needs to be in the documentation. Please provide input to the docs and hand over to the ECS team.

Comment 15 Alejandro Guizar 2010-12-23 00:44:38 UTC
Release note draft:
"This update is of interest only to jBPM installations employing multiple business calendar property files AND repeating timers. If a timer was set to repeat, the job executor had no indication of what business calendar properties file was in use when the timer was created. This update introduces a new column called CALENDARRESOURCE_ to the JBPM_JOB table that store the name of the business calendar properties resource used to create a timer.

"To avoid forcing unaffected customers to create the aforementioned column manually, this update is disabled by default. In order to enable it, interested customers must replace the mapping resource "org/jbpm/job/Timer.hbm.xml" with "org/jbpm/job/Timer.calendar.hbm.xml" in their Hibernate configuration, in addition to creating the column.

Comment 16 Julian Coleman 2010-12-24 10:51:06 UTC
Release Notes Docs Status: Added: Not Yet Documented


Comment 18 Dana Mison 2011-01-05 00:14:46 UTC
Writer: Added: dlesage


Comment 19 David Le Sage 2011-07-14 04:21:46 UTC
Release Notes Docs Status: Removed: Not Yet Documented Added: Documented as Resolved Issue
Release Notes Text: Added: If your JBoss BPM installation employs multiple business calendar property files and you had set a timer to repeat, the job executor would not know which business calendar properties file was in use when the timer was created. This update introduces a new column called CALENDARRESOURCE_ to the JBPM_JOB table that store the name of the business calendar properties resource used to create a timer.

To avoid forcing unaffected customers to create the aforementioned column manually, this update is disabled by default. In order to enable it, replace the  org/jbpm/job/Timer.hbm.xml mapping resource with org/jbpm/job/Timer.calendar.hbm.xml in the Hibernate configuration, after you have created the column.


Comment 20 David Le Sage 2011-07-14 04:22:40 UTC
Release note added, based on Alejandro's draft.

Comment 21 Martin Vecera 2011-11-15 08:57:29 UTC
Verified.


Note You need to log in before you can comment on or make changes to this bug.