Bug 780521 (SOA-2954) - Multiple 5.1 SOA-P quickstarts include eclipse .settings and .project files
Summary: Multiple 5.1 SOA-P quickstarts include eclipse .settings and .project files
Keywords:
Status: CLOSED NEXTRELEASE
Alias: SOA-2954
Product: JBoss Enterprise SOA Platform 5
Classification: JBoss
Component: Examples
Version: 5.1.0 GA
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 5.2.0 GA
Assignee: Feng Qian
QA Contact:
URL: http://jira.jboss.org/jira/browse/SOA...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-02 21:24 UTC by Len DiMaggio
Modified: 2014-07-25 03:33 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-08 01:14:47 UTC
Type: Bug


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RIFTSAW-417 0 None None None Never
Red Hat Issue Tracker SOA-2954 0 None None None Never

Description Len DiMaggio 2011-03-02 21:24:59 UTC
project_key: SOA

Multiple 5.1 SOA-P quickstarts include eclipse .settings and .project files:

find . -name .project -print
./publish_as_webservice_inonly/src/.project
./bpel_simple_correlation/.project
./bpel_math/.project
./bpel_salutations/.project
./bpel_simple_pick/.project
./bpel_say_hello/.project
./bpel_hello_world_header_ode/.project
./bpel_hello_world/.project
./bpel_hello_world_header_wsdl/.project
./bpel_secure_service/.project

find . -name .settings -print
./bpel_simple_correlation/.settings
./bpel_math/.settings
./bpel_loan_approval/.settings
./bpel_salutations/.settings
./bpel_simple_pick/.settings
./bpel_say_hello/.settings
./bpel_service_handler/.settings
./bpel_hello_world_header_ode/.settings
./bpel_simple_invoke/.settings
./bpel_hello_world/.settings
./bpel_hello_world_header_wsdl/.settings
./bpel_secure_service/.settings
./bpel_secure_invoke/.settings

find . -name .classpath  -print
./publish_as_webservice_inonly/src/.classpath

Comment 1 Anne-Louise Tangring 2011-04-11 13:20:10 UTC
Link: Added: This issue is related to SOA-2988


Comment 2 Brian Fitzpatrick 2011-06-20 23:03:08 UTC
Why is this a concern? Some of the examples are meant to be run at the command line and others are meant to be imported into the tooling. Is it a naming issue? Consistency? What's the heart of this issue?

Comment 3 Kevin Conner 2011-06-21 10:07:33 UTC
They need to be removed but Brian is not the correct assignee for this task.

publish_as_webservice is an ESB quickstart, the rest appear to be riftsaw quickstarts.

This should either be handled by the projects or cleaned up during the platform build.

Comment 4 Brian Fitzpatrick 2011-06-21 13:24:53 UTC
Kevin, the examples were added by Bob Brodt for the BPEL Editor. But that's neither here nor there. 

You didn't answer the question however. Is there a hard and fast requirement that examples included with the runtime don't include tooling artifacts? What's at the heart of this need for cleanup?

Comment 5 Kevin Conner 2011-06-21 13:28:15 UTC
The ESB artifacts are a consequence of checking the development files and should not be present in the release.  I had assumed that the BPEL ones were the same.

Comment 6 Kevin Conner 2011-06-21 13:37:31 UTC
Just checked the SOA 5.1 and it looks like the following quickstarts do not have valid eclipse files

bpel_loan_approval/.settings
bpel_secure_invoke/.settings
bpel_secure_service (wrong name)
bpel_service_handler/.settings
bpel_simple_invoke/.settings

and add the ESB one (publish_as_webservice_inonly/src/.project)


Comment 7 Brian Fitzpatrick 2011-06-21 13:45:21 UTC
Bob, can you look into this to see what we can do to either a) make sure all of the Eclipse examples work or b) see what we need to do to remove them and make them purely available in the tooling via the Project Examples mechanism?

Comment 8 Robert (Bob) Brodt 2011-07-21 13:13:24 UTC
Sure, but since Grid is already involved in getting these sample projects into shape, he's the best one to look into this.

Grid, assigning to you.

Comment 9 tcunning 2011-07-21 14:25:19 UTC
Link: Added: This issue is related to JBESB-3640


Comment 10 tcunning 2011-07-21 14:27:19 UTC
I created an ESB task for the publish_as_webservice_inonly one, I'll grab that portion of this issue.

Comment 11 Feng Qian 2011-07-25 07:03:37 UTC
Hi guys,
I am confused what we want. Where are these bpel examples? If they come from the jboss tools bpel projects examples, of course they can work in eclipse or jboss tools, because I export them from eclipse.
You means these examples can't work on commandline just because they have .project file and .settings folder?

Comment 12 Feng Qian 2011-08-01 04:20:55 UTC
Any comments?
I found some samples from soa-p platform, these bpel samples are not from my eclipse bpel project samples, I don't know who create them. Some of them have .project and .settings, the others have not.
If only need I remove the .project and .settings, it's easy to do.
If there are other purpose, please let me know. 

Grid

Comment 13 Douglas Palmer 2011-08-10 10:57:19 UTC
These samples are from the RiftSaw distribution; AFAIK they have nothing to do with tooling. I will remove them from SOA-P.

Comment 14 Douglas Palmer 2011-08-10 12:19:50 UTC
Removed eclipse project files from RiftSaw quickstarts.

Comment 15 Robert (Bob) Brodt 2011-08-10 16:07:59 UTC
Douglas, where did you make these changes? I'm looking at https://svn.jboss.org/repos/riftsaw - all of the branches and trunk still have .project and .settings for at least some of the above mentioned bpel quickstart projects.

Also, if these eclipse artifacts are going to be removed, the projects can no longer be imported and deployed from the tooling. This will affect the Riftsaw documentation (docbook and various readme files) in many places which means another trip to the publishers.

Is this *really* something we want to tackle now, especially considering this is a "minor" bug?

Comment 16 Douglas Palmer 2011-08-10 17:49:19 UTC
Robert, I have excluded the files from the SOA-P assembly. I am fairly confident that they should be removed as they as inconsistent with all of the other SOA-P quickstarts, which don't include eclipse project files. The inconsistency probably raises the priority of the issue.

Comment 17 Brian Fitzpatrick 2011-08-10 21:08:31 UTC
Please excuse my earlier panic attack. I deleted that comment. :)

The fact that these projects DON'T import into Eclipse with the existing .project and .settings files being in there suggests to me that removing them isn't going to cause any issues from a runtime perspective. Plus, the BPEL tooling examples appear in the JBDS 4.1 Project Examples wizard, so really this shouldn't be a big deal.  

If they imported successfully, I'd be less inclined to remove the Eclipse metadata, but since that's not the case we're probably ok with getting rid of it. 

Comment 18 Robert (Bob) Brodt 2011-08-10 21:50:45 UTC
Link: Added: This issue relates to RIFTSAW-417


Comment 19 Gary Brown 2011-08-11 09:38:32 UTC
I know Doug has excluded them from the SOA-P anyway, but I have now also removed them from riftsaw (and updated the getting started guide).

Comment 20 Len DiMaggio 2011-08-29 21:22:19 UTC
Verified fixed in ER3 build.

/jboss/local/52_ER3/jboss-soa-p-5/jboss-as/samples/quickstarts
$ find . -name .settings -print
$ find . -name .project -print


Comment 21 David Le Sage 2011-11-08 01:12:29 UTC
Temporarily reopening to update release note status.

Comment 22 David Le Sage 2011-11-08 01:14:32 UTC
Release Notes Docs Status: Added: Documented as Resolved Issue
Writer: Added: dlesage
Release Notes Text: Added: https://issues.jboss.org/browse/SOA-2954

Numerous SOA-P 5.1 quick starts included .settings and .project build files. These did not affect users but they have now been removed from the release to make it cleaner.




Note You need to log in before you can comment on or make changes to this bug.