Bug 780968 (SOA-3439) - modeshape sequencing performance predictability
Summary: modeshape sequencing performance predictability
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: SOA-3439
Product: JBoss Data Virtualization 6
Classification: JBoss
Component: ModeShape
Version: unspecified
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ER1
: 6.0
Assignee: Van Halbert
QA Contact:
URL: http://jira.jboss.org/jira/browse/SOA...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-05 14:43 UTC by Aleksandar Kostadinov
Modified: 2014-07-09 05:01 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously, use of timeouts with asynchronous sequencers was resulting in unexpected behavior. In this version of JBoss Data Virtualization you can register a JCR event listener for ModeShape events, including for completion of sequencing operations.
Clone Of:
Environment:
Last Closed: 2014-03-10 20:29:42 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
sequencer_csv.jsp (7.16 KB, application/octet-stream)
2011-10-05 17:43 UTC, Van Halbert
no flags Details
Updated sequencer jsp with event handling (3.50 KB, application/x-zip-compressed)
2013-01-25 12:32 UTC, Horia Chiorean
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker MODE-1276 0 Major Closed modeshape sequencing performance predictability 2014-03-10 20:29:17 UTC
Red Hat Issue Tracker SOA-3439 0 Major Closed modeshape sequencing performance predictability 2014-03-10 20:29:17 UTC

Description Aleksandar Kostadinov 2011-10-05 14:43:33 UTC
project_key: SOA

Hello, I'm running a script [1] that verifies sequencing is working. It awaits certain amount of time and if data is still not available, it throws. With SOA-P v5.1 seqTimeout in the script was 10 seconds and that was enough time for test to pass. To get a stable behavior I now need to set it to 500 seconds (tried 250 and was not enough). I mean that currently 10 seconds is sometimes enough but sometimes it takes over 250 seconds on a fast machine for sequenced data to become available.

I am wondering what can cause such difference.

UPDATE: Actually looking at many test executions, it seems that time is not the issue. Sequencing either happens soon or never. Passed tests never took too much time and in my last test run [2] server didn't sequence even after 500 seconds.

[1] https://svn.devel.redhat.com/repos/jboss-qa/hudson/config_repository/resources/soa/modeshape/basic-repo-test.war/sequencer_csv.jsp
[2] https://hudson.qa.jboss.com/hudson/view/SOA-Release/job/soa-eds-plugins-and-adminshell/126/artifact/test-output/Groovy%20Test%20Suite/index.html

Comment 1 Van Halbert 2011-10-05 15:15:05 UTC
Link: Added: This issue Cloned to SOA-3440


Comment 2 Van Halbert 2011-10-05 17:43:37 UTC
Attachment: Added: sequencer_csv.jsp


Comment 3 Van Halbert 2011-10-05 17:44:55 UTC
Retry with attached sequencer_csv.jsp.  It contains changes to the logic where iterating over the nodes and re-executing the query.   If an issue is still found, please reopen.

Comment 4 Aleksandar Kostadinov 2011-10-05 18:44:15 UTC
As I commented in MODE-1276, does spec allow reordering of operations? I mean is the cause of the problem I see and is it a feature or a bug?

Comment 5 Aleksandar Kostadinov 2011-11-03 21:06:01 UTC
Labels: Added: modeshape


Comment 6 Aleksandar Kostadinov 2011-11-15 19:38:56 UTC
Having a the code changed to make things work for me is not a prove there is no problem with modeshape. Is there anything in the test code that goes against specifications? If yes, then please point that out and close the issue. If not then I think this bug needs to be taken seriously.

Comment 7 Van Halbert 2012-02-15 17:26:21 UTC
Moving to SOA 6, because this is when it was agreed ModeShape's 3.0 version and its revamp of its internal architecture will produce the performance improvements that cannot be made on a ModeShape 2.x branch for SOA 5.x.

Comment 8 Horia Chiorean 2013-01-24 15:37:38 UTC
I can confirm that in SOA 6 (ModeShape 3.x), I will be possible to be notified when a sequencing operation is finished by registering a JCR event listener for a ModeShape specific event.

This means that there will no need for variable waits & timeouts.

Comment 9 Aleksandar Kostadinov 2013-01-24 19:53:47 UTC
Horia, would you kindly provide a patch for sequencer_csv.jsp for using this feature? That can then be used in the test runs.

Comment 10 Horia Chiorean 2013-01-24 20:05:53 UTC
Looking at the JIRA issue, Randall is referring to the synchronous feature which is not yet implemented (will be in 3.3). I will provide the patch once the feature is implemented.

Comment 11 Aleksandar Kostadinov 2013-01-24 20:21:06 UTC
I meant the JCR event listener solution. Async handling is fine as long as we have a reasonable way to know when sequencing finished to test the resulting repo state.

Comment 12 Horia Chiorean 2013-01-25 12:32:44 UTC
Created attachment 687448 [details]
Updated sequencer jsp with event handling

Attached an updated jsp file together with the repository config I used for testing. The relevant part of the sequencing listener is between lines #112 and #142.

Please note that the original jsp attached is broken: doesn't compile out-of-the-box and in the case of the final check (if (i==100)) never terminates, causing a potential infinite loop.

Comment 16 belong 2013-11-19 23:29:11 UTC
Fixed before GA - setting to requires_doc_text- accordingly

Comment 17 Filip Nguyen 2014-02-12 08:10:35 UTC
JCR event listener solution is used throughout our test suite.


Note You need to log in before you can comment on or make changes to this bug.