Red Hat Bugzilla – Bug 781458
Review Request: libteam - Library for controlling team network device
Last modified: 2015-05-04 21:23:33 EDT
Spec URL: http://people.redhat.com/jpirko/libteam/libteam.spec
SRPM URL: http://people.redhat.com/jpirko/libteam/libteam-0.1-1.20120113git302672e.fc16.src.rpm
This package contains a library which is a user-space
counterpart for team network driver. It provides an API
to control team network devices.
formal review is here, see the notes explaining OK* and BAD statuses below:
BAD source files match upstream:
BAD package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (LGPLv2+). License text included in package.
OK latest version is being packaged.
BAD BuildRequires are proper.
OK compiler flags are appropriate.
BAD package builds in mock (Rawhide/i386).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths with correct scriptlets
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in devel subpackage
OK pkgconfig files in devel subpackage
OK no libtool .la droppings.
OK not a GUI app.
- sources are a git snapshot without an instruction how to obtain it (https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control)
- python subpackage should be named python-libteam (https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29)
- swig is missing in BRs
- shouldn't a default teamd config file be packaged under /etc, maybe as %ghost-ed file?
Spec URL: http://people.redhat.com/jpirko/libteam_v2/libteam.spec
SRPM URL: http://people.redhat.com/jpirko/libteam_v2/libteam-0.1-1.20120113git302672e.fc16.src.rpm
I hope I fixed that all. Except:
I do not want to put configs into /etc/. Their purpose is solely to act as examples. The plan is to put config json text directly into ifcfg scripts in future.
All issues are fixed, the package is APPROVED and I will also sponsor you in the packager group.
New Package SCM Request
Package Name: libteam
Short Description: Library for controlling team network device
Git done (by process-git-requests).