Bug 78212 - sysstat package post scripts, trigger scripts use insecure tmp files
sysstat package post scripts, trigger scripts use insecure tmp files
Status: CLOSED ERRATA
Product: Red Hat Linux
Classification: Retired
Component: sysstat (Show other bugs)
9
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nils Philippsen
Brian Brock
: Security
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2002-11-19 22:58 EST by Mike A. Harris
Modified: 2007-04-18 12:48 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2004-03-10 14:57:18 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Mike A. Harris 2002-11-19 22:58:59 EST
Subject says it all.  The sysstat package uses insecure method of
generating temporary filenames by using the PID in /tmp
Comment 1 Alan Cox 2002-12-18 20:20:43 EST
So does the isag binary it includes btw
Comment 2 Alan Cox 2002-12-18 20:24:36 EST
--- sysstat.spec~       Sat Nov 23 05:33:21 2002
+++ sysstat.spec        Wed Dec 18 20:26:44 2002
@@ -53,8 +53,8 @@
 %triggerpostun -- sysstat <= 3.3.3-1
 # earlier versions of sysstat had crontabs done in a bad way.  fix it.
 if [ `id -u` = "0" -a "$1" -ge "2" ]; then
-  egrep -v 'sysstat|sa1|sa2' /etc/crontab > /tmp/crontab.$$
-  mv /tmp/crontab.$$ /etc/crontab && chmod 644 /etc/crontab
+  egrep -v 'sysstat|sa1|sa2' /etc/crontab > /etc/crontab.tmp$$
+  mv /etc/crontab.tmp$$ /etc/crontab && chmod 644 /etc/crontab
 fi

 %preun
Comment 3 Mark J. Cox (Product Security) 2004-01-05 04:40:49 EST
still affects 9
Comment 4 Nils Philippsen 2004-01-20 10:02:09 EST
I have built packages with this fixed for RHEL2.1, RHEL3, fc2. As soon
as someone tells me (where to find documentation about) how to check
this into CVS, pipe this through beehive, feed this to QA for errata,
I'll make the fixed packages available. Sorry, but I'm new to all this
;-).
Comment 5 Nils Philippsen 2004-01-29 14:28:21 EST
isag tmp hole is also fixed in sysstat-4.0.1-8 (for RHEL2.1), using
mktemp.
Comment 6 Mark J. Cox (Product Security) 2004-03-10 14:57:18 EST
An errata has been issued which should help the problem described in this bug report. 
This report is therefore being closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files, please follow the link below. You may reopen 
this bug report if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2004-053.html

Note You need to log in before you can comment on or make changes to this bug.