Created attachment 555546 [details] Use nss's own error mapping facilities and fix usage string Description of problem: keyutil has error reporting code which is no longer needed. Since the 3.13 release nss has support for localizable error strings via the PORT_ErrorToString and PORT_ErrorToName macros. keyutil should use those instead of rolling its own error code to string conversion routines. Relying on nss for the mapping will keep up with changes in nss automatically. This will also result some welcome code size reduction which is always welcome. While at it, please fix the hard to read usssage message. When one types keyutil --help the usage display is unreadable. It just needs line breaks Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Comment on attachment 555546 [details] Use nss's own error mapping facilities and fix usage string Bob, since you reviewed the upstream patch that makes this enhancement possible, could you review this one also? Thanks.
Comment on attachment 555546 [details] Use nss's own error mapping facilities and fix usage string The only question is will the build requires for NSS need to be updated (the Requires should be updated because the new symbol in NSS util should be picked up at link time and will insert a new version number dependency in the rpm. bob
(In reply to comment #2) Even though Rawhide/F-16/F-15 are at 3.13.1 and my scratch build succeded I should update the spec file with the minimum nss (nss-util) version required. Good catch, thank you.
crypto-utils-2.4.1-34.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/crypto-utils-2.4.1-34.fc16
Package crypto-utils-2.4.1-34.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing crypto-utils-2.4.1-34.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-5500/crypto-utils-2.4.1-34.fc16 then log in and leave karma (feedback).
crypto-utils-2.4.1-34.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.