Spec URL: http://marionline.fedorapeople.org/packages/SPECS/akonadi-google.spec SRPM URL: http://marionline.fedorapeople.org/packages/SRPMS/akonadi-google-0.2-9.20120119git754771b.fc16.src.rpm Description: Akonadi Resources for accessing Google services, like Google Calendar, Google Tasks and Google Contacts. This project is similar to akonadi-googledata. Akonadi-google is written in Qt/C++ and the upstream create a new library to interact with google calendar: libkgoogle. Akonadi-googledata is written using C and libgcal, written in C language too but there are no update from months... This package is created from a git snapshot. I am strict in contact with upstream. From akonadi-google source rpm I create five packages: - libkgoogle (the library to interact to google services); - libkgoogle-devel (developer library); - akonadi-google-calendar (Akonadi Resource for Google Calendar); - akonadi-google-contacts (Akonadi Resource for Google Contacts); - akonadi-google-tasks (Akonadi Resource for Google Tasks).
Name: ok License: ok Source: It should be stated clearly in the comment in specfile how can be the tarball obtained from git BRs/Reqs: see below Macros used consistently: ok ldconfig: ok Desktop file validations: NA Locales: NA Docs: install at least README to %doc. According to guidelines you should also ping upstream to add license to tarball. Devel: ok Files: ok Build: ok rpmlint: no need to fix ./akonadi-google.spec: W: invalid-url Source0: akonadi-google-0.2-git754771b.tar.gz akonadi-google-calendar.x86_64: W: no-documentation akonadi-google-calendar.x86_64: W: no-manual-page-for-binary akonadi_googlecalendar_resource akonadi-google-contacts.x86_64: W: no-documentation akonadi-google-contacts.x86_64: W: no-manual-page-for-binary akonadi_googlecontacts_resource akonadi-google-tasks.x86_64: W: no-documentation akonadi-google-tasks.x86_64: W: no-manual-page-for-binary akonadi_googletasks_resource libkgoogle-devel.x86_64: W: spelling-error Summary(en_US) akonadi -> Kodiak libkgoogle-devel.x86_64: W: spelling-error Summary(en_US) google -> Google, goggle, googly libkgoogle-devel.x86_64: W: spelling-error %description -l en_US akonadi -> Kodiak libkgoogle-devel.x86_64: W: spelling-error %description -l en_US google -> Google, goggle, googly libkgoogle-devel.x86_64: W: no-documentation I have some comments to subpackages, its only my recommendations, I'm open to other suggestions: * contacts, calendar and tasks subpackage should Require: libkgoogle subpackage with same version to prevent breakage on API/ABI change * I would let the base package empty and add Requires to all subpackages (except devel). This makes it easier for user to install all of them at once. Add section %files without any content to generate base package too.
Spec URL: http://marionline.fedorapeople.org/packages/SPECS/akonadi-google.spec SRPM URL: http://marionline.fedorapeople.org/packages/SRPMS/akonadi-google-0.2-10.20120120git11bf6ad.fc16.src.rpm Changelog is: - Update Specfile with comment #1 - Update to git snapshot 11bf6ad40dd93eda1f880a99d592009ea3ff47ac - Include LICENSE
Thanks for fixing all the issues. Setting fedora-review+.
Thank you Radek for your review!
New Package SCM Request ======================= Package Name: akonadi-google Short Description: Akonadi Resources for accessing Google services Owners: marionline Branches: f15 f16 InitialCC:
Git done (by process-git-requests).
akonadi-google-0.2-11.20120121gitbe021c6.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/akonadi-google-0.2-11.20120121gitbe021c6.fc16
akonadi-google-0.2-11.20120121gitbe021c6.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/akonadi-google-0.2-11.20120121gitbe021c6.fc15
akonadi-google-0.2-11.20120121gitbe021c6.fc15 has been pushed to the Fedora 15 stable repository.
akonadi-google-0.2-11.20120121gitbe021c6.fc16 has been pushed to the Fedora 16 stable repository.