Bug 783456 - Review Request: perl-URI-Find-Simple - Simple interface to URI::Find
Summary: Review Request: perl-URI-Find-Simple - Simple interface to URI::Find
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-20 13:56 UTC by Petr Šabata
Modified: 2012-01-24 11:34 UTC (History)
3 users (show)

Fixed In Version: perl-URI-Find-Simple-1.03-1.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-24 11:34:04 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2012-01-20 13:56:12 UTC
Spec URL: http://psabata.fedorapeople.org/pkgs/perl-URI-Find-Simple/perl-URI-Find-Simple.spec
SRPM URL: http://psabata.fedorapeople.org/pkgs/perl-URI-Find-Simple/perl-URI-Find-Simple-1.03-1.fc16.src.rpm
Description:
URI::Find is all very well, but sometimes you just want a list of the links
in a given piece of text, or you want to change all the URLs in some text
somehow, and don't want to mess with callback interfaces.

Comment 1 Petr Pisar 2012-01-24 08:25:18 UTC
Source file is original. Ok.
URL and Source0 are alive Ok.
Summary verified from lib/URI/Find/Simple.pm. Ok.
License verified from lib/URI/Find/Simple.pm. Ok.

Description verified from lib/URI/Find/Simple.pm.
TODO: Add second paragraph that explains explicitly what this package do.

No XS code, noarch BuildArch is Ok.

TODO: Build-require `perl(lib)' for tests (t/find.t:3).

All tests pass. Ok.

$ rpmlint perl-URI-Find-Simple.spec ../SRPMS/perl-URI-Find-Simple-1.03-1.fc17.src.rpm ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jan 24 09:09 /usr/share/doc/perl-URI-Find-Simple-1.03
-rw-r--r--    1 root    root                      325 Oct 25  2010 /usr/share/doc/perl-URI-Find-Simple-1.03/Changes
-rw-r--r--    1 root    root                     2621 Jan 24 09:09 /usr/share/man/man3/URI::Find::Simple.3pm.gz
drwxr-xr-x    2 root    root                        0 Jan 24 09:09 /usr/share/perl5/vendor_perl/URI
drwxr-xr-x    2 root    root                        0 Jan 24 09:09 /usr/share/perl5/vendor_perl/URI/Find
-rw-r--r--    1 root    root                     2954 Oct 25  2010 /usr/share/perl5/vendor_perl/URI/Find/Simple.pm
File permissions and layout are Ok.

$ rpm -q --requires  -p ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm | sort | uniq -c
      1 perl(Carp)  
      1 perl(Encode)  
      1 perl(:MODULE_COMPAT_5.14.2)  
      1 perl(strict)  
      1 perl(URI::Find)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm | sort | uniq -c
      1 perl(URI::Find::Simple) = 1.03
      1 perl-URI-Find-Simple = 1.03-1.fc17
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3728154). Ok.

Otherwise package is in line with Fedora and Perl packaging guidelines.


Please consider fixing all `TODO' items before building this package.

Resolution: Package APPROVED.

Comment 2 Petr Šabata 2012-01-24 08:55:39 UTC
New Package SCM Request
=======================
Package Name: perl-URI-Find-Simple
Short Description: Simple interface to URI::Find
Owners: psabata mmaslano ppisar
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2012-01-24 11:04:36 UTC
Git done (by process-git-requests).

Comment 4 Petr Šabata 2012-01-24 11:34:04 UTC
Thank you, guys.

Both TODOs have been fixed in the imported package.


Note You need to log in before you can comment on or make changes to this bug.