Bug 783519 - Uninitialized ActionError exception class is used in models
Summary: Uninitialized ActionError exception class is used in models
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: CloudForms Cloud Engine
Classification: Retired
Component: aeolus-conductor
Version: 1.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
Assignee: Jan Provaznik
QA Contact: wes hayutin
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-20 17:29 UTC by Jan Provaznik
Modified: 2012-08-30 17:17 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-30 17:17:16 UTC

Attachments (Terms of Use)
msg (259.11 KB, image/png)
2012-02-24 07:46 UTC, Aziza Karol 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Jan Provaznik 2012-01-20 17:29:47 UTC 
app/models/deployment.rb and app/models/instance.rb use on some places ActionError exception. This exception is defined in application_service -> it's accessible only in controllers.

Anytime ActionError is used in model, conductor throws an exception. For example if invalid action is queued for an instances (trying to stop an instance which is already stopped)
Comment 1 Jan Provaznik 2012-01-20 17:59:38 UTC 
patch sent: https://fedorahosted.org/pipermail/aeolus-devel/2012-January/008233.html
Comment 2 Jan Provaznik 2012-01-24 10:51:42 UTC 
commit ad1b2c381c9d9ffe7b09ecc5873511627f378be0
Comment 3 Steve Linabery 2012-01-25 00:13:07 UTC 
ad1b2c3 in aeolus-conductor-0.8.0-11.el6
Comment 4 wes hayutin 2012-02-24 04:52:01 UTC 
need a testplan.. how does qe test this?
Comment 5 Jan Provaznik 2012-02-24 07:41:08 UTC 
stopping a stopped instance should verify this - you should get flash error saying the action is invalid, w/o this patch you should probably get some error about unknown class
Comment 6 Aziza Karol 2012-02-24 07:44:49 UTC 
verified by stopping a stopped instance.

User get a flash error saying that stop is an invalid action. see attached screenshot

verified on:
# rpm -qa | grep aeolus
rubygem-aeolus-image-0.3.0-9.el6.noarch
rubygem-aeolus-cli-0.3.0-10.el6.noarch
aeolus-all-0.8.0-35.el6.noarch
aeolus-conductor-doc-0.8.0-35.el6.noarch
aeolus-conductor-daemons-0.8.0-35.el6.noarch
aeolus-configure-2.5.0-15.el6.noarch
aeolus-conductor-0.8.0-35.el6.noarch
Comment 7 Aziza Karol 2012-02-24 07:46:58 UTC 
Created attachment 565518 [details]
msg
Note You need to log in before you can comment on or make changes to this bug.