Spec URL: https://raw.github.com/remicollet/remirepo/master/php-phpunit-PHPUnit-SkeletonGenerator/php-phpunit-PHPUnit-SkeletonGenerator.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.remi.src.rpm Description: Tool that can generate skeleton test classes from production code classes and vice versa. -- PHPUnit 3.6.8 have marked `--skeleton-class` and `--skeleton-test` as deprecated. Please use the `phpunit-skelgen` tool that is provided by the `PHPUnit_SkeletonGenerator` package instead.
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [-]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL [x]: MUST Sources contain only permissible code or content. [-]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [-]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [-]: MUST Rpmlint output is silent. rpmlint php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc17.src.rpm php-phpunit-PHPUnit-SkeletonGenerator.src: W: spelling-error %description -l en_US versa -> avers, verse, verso 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc17.noarch.rpm php-phpunit-PHPUnit-SkeletonGenerator.noarch: W: spelling-error %description -l en_US versa -> avers, verse, verso php-phpunit-PHPUnit-SkeletonGenerator.noarch: W: no-manual-page-for-binary phpunit-skelgen 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/builder/783632/PHPUnit_SkeletonGenerator-1.0.0.tgz : MD5SUM this package : c879684cfdbafb0c629df93a58c3e50e MD5SUM upstream package : c879684cfdbafb0c629df93a58c3e50e [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Scriptlets must be sane, if used. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST Rpmlint output is silent. rpmlint php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc17.src.rpm php-phpunit-PHPUnit-SkeletonGenerator.src: W: spelling-error %description -l en_US versa -> avers, verse, verso 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc17.noarch.rpm php-phpunit-PHPUnit-SkeletonGenerator.noarch: W: spelling-error %description -l en_US versa -> avers, verse, verso php-phpunit-PHPUnit-SkeletonGenerator.noarch: W: no-manual-page-for-binary phpunit-skelgen 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Generated by fedora-review 0.1.2 External plugins: Comments: * License: classic BSD 3 clauses (OK) * since you plan to package php-phpunit-PHPUnit-SkeletonGenerator in EPEL 5, all MUST about BuildRoot and defattr will be ignored accordingly to guidelines * rpmlint output is OK * installs and works fine * mockbuilds for EPEL5/EPEL6 targets It respects the Fedora general & php specific guidelines except for the license file which is not included in %doc (unless there's a specific php/PEAR guideline i'm not aware of) As soon as you clear the license file issue (either by including in %doc or pointing me the corresponding guideline), i will approve this package.
LICENSE, provided by upstream is in the %doc rpm -ql --docfiles php-phpunit-PHPUnit-SkeletonGenerator /usr/share/doc/pear/PHPUnit_SkeletonGenerator/ChangeLog.markdown /usr/share/doc/pear/PHPUnit_SkeletonGenerator/LICENSE /usr/share/doc/pear/PHPUnit_SkeletonGenerator/README.markdown %{pear_docdir} is the common place for doc, when provided and installed by upstream (PHP Guidelines)
Ok, rpmls confirmed that so i hereby approve this package into Fedora Packages Collection. I was terrified by the idea that you might be fallible. ;)
Thanks for the review New Package SCM Request ======================= Package Name: php-phpunit-PHPUnit-SkeletonGenerator Short Description: Tool that can generate skeleton test classes Owners: remi Branches: f15 f16 el6 InitialCC:
Git done (by process-git-requests).
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc16
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc15
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.el6
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc16 has been pushed to the Fedora 16 testing repository.
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc16 has been pushed to the Fedora 16 stable repository.
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc15 has been pushed to the Fedora 15 stable repository.
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.